From owner-freebsd-net@FreeBSD.ORG Wed Feb 10 17:26:36 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1C9FB106566C; Wed, 10 Feb 2010 17:26:36 +0000 (UTC) (envelope-from balajig81@gmail.com) Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.25]) by mx1.freebsd.org (Postfix) with ESMTP id B1AB48FC14; Wed, 10 Feb 2010 17:26:34 +0000 (UTC) Received: by qw-out-2122.google.com with SMTP id 5so72417qwd.7 for ; Wed, 10 Feb 2010 09:26:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=0W5/HyFJXp2YIaPsTOpqORgpAPlh3kDmgEHmDhS4WH8=; b=RNR5I9thZRyd7kyhtdMLeaAl7Wh3KaRw7ge6/roxP6XK87p8KWGL1wq/x7f82k07Gp etRLNbDU0hMIlTfDhkLEEo9f1qoqx3f92KFDbFc7LLtZLCSbmJaZ+/SKz2PIZ5yERpfK D1R9djb/al6IixToswviRjKXF14BlrMFC8cWg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=nFr95wdRqSXBl9yWRTNVPZpgfOJTBruv7+MV2GMgm+owl6x2UYx49gcIfdcINRE7be TwOcTINeUlrnu/KryfzspWiwwwNORugIztPXYZoftDnyvJIAJEBvnm5w8nfEMJVyweDX 8Tz0/Z7a2BGb43ie7oc1+urctID1PKE54Qi+I= MIME-Version: 1.0 Received: by 10.142.56.6 with SMTP id e6mr327213wfa.191.1265822791876; Wed, 10 Feb 2010 09:26:31 -0800 (PST) In-Reply-To: References: <6dd1343e1002080739m38f4deffr604c71e5036389a4@mail.gmail.com> <6dd1343e1002092253j5b111d42m7c354ca372241dde@mail.gmail.com> Date: Wed, 10 Feb 2010 22:56:31 +0530 Message-ID: <6dd1343e1002100926mbbaf79epa8aeca5adb078d73@mail.gmail.com> From: Balaji G To: jhell Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-net@freebsd.org, "Li, Qing" , Qing Li Subject: Re: [PATCH] net:: ECMP Phase 1 Fixes for FreeBSD 7.2 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2010 17:26:36 -0000 Hi Jhell Thanks yeah i got it. Jassal told me this :) sorry i didnt look at it. Will correct it when i generate the patches the next time as i am working on it Thanks for your feedback. I hope i get in touch with some on the task list soon :) Cheers, - Balaji On Wed, Feb 10, 2010 at 10:38 PM, jhell wrote: > > On Wed, 10 Feb 2010 01:53, balajig81@ wrote: > >> Hi Jhell >> >> Delete keys get in the way some times ;) >>> >> >> I am sorry i didn't understand your comment. Is it wrong or should i >> change >> something, please let me know so that i could create an other patch . >> >> > Please see below. > > > PS: I had also sent an email to the list to take up some items mentioned >> in >> the Wiki Page under the networking section. It would be nice if by any >> chance you know who's the contact person :). for those activities. >> >> > I do not remember who the contact person is at the moment but it would be > safe to say he/she is probably watching mailing list. > > > Thanks for your feedback and time :) >> >> Thanks, >> Cheers, >> - Balaji >> >> >> On Wed, Feb 10, 2010 at 12:11 PM, jhell wrote: >> >> >>> On Mon, 8 Feb 2010 10:39, balajig81@ wrote: >>> >>> Hi Everybody >>>> >>>> Please find attached the patch files which contains the backported code >>>> for >>>> ECMP for FreeBSD 7.2. I have back ported the code from 8.0. I have done >>>> some >>>> basic testing with these patches rolled in. These are the phase 1 fixes >>>> and >>>> i would continue to work on this and back port few other stuff too. It >>>> would >>>> be great if someone could roll in this to 7.2, test it and give me their >>>> valuable feedback. >>>> >>>> This is my first Patch for FreeBSD community and i am really excited >>>> about >>>> this and look forward to it. >>>> >>>> Thanks for your time. >>>> >>>> Cheers, >>>> - Balaji >>>> >>>> >>>> In ecmp_patch1 you have, >>> >>> @@ -320,8 +320,9 @@ >>> #endif >>> >>> extern int in6_inithead(void **head, int off); >>> -extern int in_inithead(void **head, int off); >>> +extern int in_inthead(void **head, int off); >>> >>> > Problem is with the above two lines explicitly "in_inthead" should be > "in_inithead" but it looked to me like it was a mistake and that you did not > mean to delete the "i" which is why I said the following. > > > ?? >>> >>> Delete keys get in the way some times ;) >>> >>> -- >>> >>> jhell >>> >>> >>> >> > > Best regards. > > -- > > jhell > >