Date: Wed, 1 Jul 2020 10:28:15 -0500 From: Jason Bacon <bacon4000@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r540967 - in head/net/lualdap: . files Message-ID: <a5b62c40-e342-829c-24fc-9f8b4a37874d@gmail.com> In-Reply-To: <20200701151607.GA6554@FreeBSD.org> References: <202007011406.061E6Cxt041119@repo.freebsd.org> <20200701151607.GA6554@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2020-07-01 10:16, Alexey Dokuchaev wrote: > On Wed, Jul 01, 2020 at 02:06:12PM +0000, Li-Wen Hsu wrote: >> New Revision: 540967 >> URL: https://svnweb.freebsd.org/changeset/ports/540967 >> >> Log: >> Update to 1.2.5 >> =20 >> ... >> -MAKE_ARGS+=3D LUA_LIBDIR=3D"${LUA_LIBDIR}" \ >> - LUA_INC=3D"${LUA_INCDIR}" \ >> - OPENLDAP_LIB=3D"-L${LOCALBASE}/lib -lldap" \ >> - LUA_VERSION_NUM=3D"${LUA_VER_STR}0" \ >> - CC=3D"${CC}" >> +MAKE_ARGS+=3D CPPFLAGS=3D"-I${LOCALBASE}/include -I${LUA_INCDIR}" \ >> + LDFLAGS=3D"-L${LOCALBASE}/lib" \ >> + CC=3D${CC} > Dropping quotes around ${CC} can potentially break things and also > had contributed some unnecessary repo churn. :( > > ./danfe I would have thought ${CC} is always just the compiler name sans=20 flags/whitespace, but danfe is correct.=C2=A0 There's one case in Mk that= =20 would call for quotes: FreeBSD coral.acadix=C2=A0 bacon ~ 1004: grep -r=C2=A0 ^CC=3D=C2=A0 /usr/= ports/Mk/ [snip] /usr/ports/Mk/bsd.port.mk:CC=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 ${XCC} --sysroot=3D${CROSS_SYSROOT} --=20 Earth is a beta site.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a5b62c40-e342-829c-24fc-9f8b4a37874d>