From nobody Sun Feb 19 16:48:34 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PKWhf3pYRz3rQNN; Sun, 19 Feb 2023 16:48:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PKWhf3HBkz3Q54; Sun, 19 Feb 2023 16:48:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676825314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JpHYV2v2WLFZnORx9W3IFXZKUJJ7oyk9uNcG0+Edo10=; b=qp5CmhoOGYnPQpnJCb5f4GwN6kyO9Y3jsPFvR6ipEZovIOC6jjiMTJ3UDjSIlg7RJg2u9b SYKl+gzcxZNRkd0nUEq1EjZ2s55WhvKGyXi0aPyuyPCf/rVaEPB/8BuPvPjgi8uFY3wI43 ck4VVmGySpuu7+xTHEWfCgbRgP3zdwtpZdKdoEhfyGP4ayKj+W/bLjhu4NnvHfVWobl8LT F/qcO0JrvGd29BgTeC2KFsmBnewmyu82J5V43HFJs3zOj5CcS+9lYYH4iKRd/gb4p4KC/v 7FpPI4jqp1GFbTe4jKM+6J5BpesAqEXCjtATscI8IKdOFxyvHI5d4yCsKhhfwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676825314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JpHYV2v2WLFZnORx9W3IFXZKUJJ7oyk9uNcG0+Edo10=; b=LdMiOVJAm0IfzThe5GslPI7KzS8t0/SY64qG7X1I4Fwl1nzsBQj31lAikKWkGazSWdt+s1 gFPgxsaZr7tTg0vIU6wSgOwVWSjcu1DMPF5DHvtrQh6RjUIEwWGyu1HUY6h86fpkG8LJRN ExTI7gh2qmMyZqjdpUv1bp6tEoS8IIAnmxI7azGAVaeANTEm/YxwaSrPba98JGtjLle1rI FPfHC5PoiiJQfCINmAbsxv1ZlAf9LegzO8iAVWhkEvwFNPIafCtEEj71OB8So+f2gPjtre tQRAhOVncUyt47+UozNTrZEfE+YjUx/45xvGnzr0gHh+OZW+8rh9nT2mWVJqBQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676825314; a=rsa-sha256; cv=none; b=ocHmSii30uuu3GBShtZhIFAEAiBzCalmhHXjtl0Z+nN282JptO9VOHLU0TsZul9d/mNTIf fjwzmj800Wl2d9Ui8tPMO3cAbKDGpaO4UOmk8y6vmf4nFaSEJtnLtVuAwoSF/OK79XPQ79 p+pPnJc1CG9FiZr6Ax1m2gIhpGex9xAtccJ+aBGwqj8uWDuRh9v98xzAg6jDaFcEohBAR4 ksiwFNH8anYsIwygsxgleBdig+oe3PLjMehkT3faGb/3S5SCioLePgYjhjiXXGeK8liz8w J88rRXZOmkRTOKjtrT2/y5k0YWhQHv02qyHNbJCKSkrgn/g6gn+q/QcJOAJxPA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PKWhf2Kxsz17w2; Sun, 19 Feb 2023 16:48:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 31JGmYa0037858; Sun, 19 Feb 2023 16:48:34 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 31JGmYfN037857; Sun, 19 Feb 2023 16:48:34 GMT (envelope-from git) Date: Sun, 19 Feb 2023 16:48:34 GMT Message-Id: <202302191648.31JGmYfN037857@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alan Somers Subject: git: 57756461548b - stable/13 - fusefs: fix some resource leaks List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 57756461548b813c288e190900de31e847e412f9 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=57756461548b813c288e190900de31e847e412f9 commit 57756461548b813c288e190900de31e847e412f9 Author: Alan Somers AuthorDate: 2023-02-11 23:43:30 +0000 Commit: Alan Somers CommitDate: 2023-02-19 15:41:24 +0000 fusefs: fix some resource leaks fusefs would leak tickets in three cases: * After FUSE_CREATE, if the server returned a bad inode number. * After a FUSE_FALLOCATE operation during VOP_ALLOCATE * After a FUSE_FALLOCATE operation during VOP_DEALLOCATE Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D38526 (cherry picked from commit 1bdf879b97b686a8f36fdba050b68f9e7493f363) MFC Note: changes to VOP_DEALLOCATE are not MFCed, because that VOP does not exist in stable/13. --- sys/fs/fuse/fuse_vnops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/fs/fuse/fuse_vnops.c b/sys/fs/fuse/fuse_vnops.c index eaace113d67e..7fd96ff639ff 100644 --- a/sys/fs/fuse/fuse_vnops.c +++ b/sys/fs/fuse/fuse_vnops.c @@ -668,6 +668,7 @@ fuse_vnop_allocate(struct vop_allocate_args *ap) } } + fdisp_destroy(&fdi); return (err); } @@ -1104,6 +1105,7 @@ fuse_vnop_create(struct vop_create_args *ap) uint64_t nodeid = feo->nodeid; uint64_t fh_id = foo->fh; + fdisp_destroy(fdip); fdisp_init(fdip, sizeof(*fri)); fdisp_make(fdip, FUSE_RELEASE, mp, nodeid, td, cred); fri = fdip->indata;