Date: Thu, 06 Dec 2012 09:00:52 -0800 From: Alfred Perlstein <bright@mu.org> To: Jaakko Heinonen <jh@FreeBSD.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-9@freebsd.org Subject: Re: svn commit: r243942 - stable/9/sbin/fsck_msdosfs Message-ID: <50C0CF44.6040802@mu.org> In-Reply-To: <201212060835.qB68ZkGe099714@svn.freebsd.org> References: <201212060835.qB68ZkGe099714@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/6/12 12:35 AM, Jaakko Heinonen wrote: > Author: jh > Date: Thu Dec 6 08:35:46 2012 > New Revision: 243942 > URL: http://svnweb.freebsd.org/changeset/base/243942 > > Log: > MFC r242511: Print a newline after the error message. > > PR: bin/168447 > > Modified: > stable/9/sbin/fsck_msdosfs/check.c > Directory Properties: > stable/9/sbin/fsck_msdosfs/ (props changed) > > Modified: stable/9/sbin/fsck_msdosfs/check.c > ============================================================================== > --- stable/9/sbin/fsck_msdosfs/check.c Thu Dec 6 08:32:28 2012 (r243941) > +++ stable/9/sbin/fsck_msdosfs/check.c Thu Dec 6 08:35:46 2012 (r243942) > @@ -68,6 +68,7 @@ checkfilesys(const char *fname) > > if (dosfs < 0) { > perror("Can't open"); > + printf("\n"); > return 8; > } > > I think perror writes to STDERR, printf to STDOUT. (am I wrong?) Does fsck_msdosfs tie the two together? You might better use warn()? sorry if this is superfluous concern, it just popped out as potentially wrong. -Alfred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50C0CF44.6040802>