From owner-cvs-all Fri Jul 12 12: 6:48 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D603937B401; Fri, 12 Jul 2002 12:06:43 -0700 (PDT) Received: from mta5.snfc21.pbi.net (mta5.snfc21.pbi.net [206.13.28.241]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2ADB043E5E; Fri, 12 Jul 2002 12:06:43 -0700 (PDT) (envelope-from hsu@FreeBSD.org) Received: from FreeBSD.org ([63.193.112.125]) by mta5.snfc21.pbi.net (iPlanet Messaging Server 5.1 (built May 7 2001)) with ESMTP id <0GZ5004ILH36IU@mta5.snfc21.pbi.net>; Fri, 12 Jul 2002 12:06:42 -0700 (PDT) Date: Fri, 12 Jul 2002 12:06:55 -0700 From: Jeffrey Hsu Subject: Re: cvs commit: src/sys/netinet udp_usrreq.c In-reply-to: Message from Don Lewis "of Fri, 12 Jul 2002 04:07:12 PDT." <200207121107.g6CB7Cwr013757@gw.catspoiler.org> To: Don Lewis Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Message-id: <0GZ5004IMH36IU@mta5.snfc21.pbi.net> MIME-version: 1.0 X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > I've been doing some digging through the code and it looks to me like > both the INP_LOCK() and inp->inp_socket == NULL test can be eliminated. The inp lock is needed for sure. It does look like the inp->inp_socket == NULL test can be eliminated, but I didn't want to introduce any extraneous changes with the inp locking patch, so that change is left for a later round. > The inp->inp_socket == NULL check shows up in the code > listing in _TCP/IP Illustrated Volume 2_, but there doesn't seem to be > any need for it there. It probably slipped in to "fix" panic some time > in the deep dark past when there were probably locking problems in the > code. This is where the CSRG SCCS archive comes in real handy. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message