From owner-freebsd-current@FreeBSD.ORG Mon Sep 9 21:17:16 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 85822952; Mon, 9 Sep 2013 21:17:16 +0000 (UTC) (envelope-from ohartman@zedat.fu-berlin.de) Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1ADAD24CF; Mon, 9 Sep 2013 21:17:15 +0000 (UTC) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost1.zedat.fu-berlin.de (Exim 4.80.1) with esmtp (envelope-from ) id <1VJ8pe-003JsV-FU>; Mon, 09 Sep 2013 23:17:14 +0200 Received: from e179065126.adsl.alicedsl.de ([85.179.65.126] helo=thor.walstatt.dyndns.org) by inpost2.zedat.fu-berlin.de (Exim 4.80.1) with esmtpsa (envelope-from ) id <1VJ8pe-000ZJu-Aa>; Mon, 09 Sep 2013 23:17:14 +0200 Date: Mon, 9 Sep 2013 23:17:13 +0200 From: "O. Hartmann" To: Ivan Klymenko Subject: Re: CURRENT r255426: x11/nvidia-driver: nvidia_subr.c:835:46: error: too few arguments to function call, expected 10, have 9 (VM_PROT_READ | VM_PROT_WRITE), 0); Message-ID: <20130909231713.34ebfbdd@thor.walstatt.dyndns.org> In-Reply-To: <20130910000237.6b5604da@nonamehost.local> References: <20130909223748.61dd8859@thor.walstatt.dyndns.org> <20130910000237.6b5604da@nonamehost.local> Organization: FU Berlin X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.19; amd64-portbld-freebsd10.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/UrICAPLQIU4o8yBNhfpaT_O"; protocol="application/pgp-signature" X-Originating-IP: 85.179.65.126 Cc: FreeBSD CURRENT , FreeBSD Ports X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Sep 2013 21:17:16 -0000 --Sig_/UrICAPLQIU4o8yBNhfpaT_O Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, 10 Sep 2013 00:02:37 +0300 Ivan Klymenko wrote: > =D0=92 Mon, 9 Sep 2013 22:37:48 +0200 > "O. Hartmann" =D0=BF=D0=B8=D1=88=D0=B5=D1= =82: >=20 > > x11/nvidia-driver (as well as emulators/virtualbox-ose-kmod) do not > > compile on FreeBSD 10.0-CURRENT #0 r255426: Mon Sep 9 21:35:43 > > CEST 2013 amd64. > >=20 > > The error is: > >=20 > > x11/nvidia-driver: > >=20 > > --- nvidia_subr.o --- > > nvidia_subr.c:835:46: error: too few arguments to function call, > > expected 10, have 9 (VM_PROT_READ | VM_PROT_WRITE), 0); > > ^ > > @/vm/vm_map.h:368:1: note: 'vm_map_find' declared here > > int vm_map_find(vm_map_t, vm_object_t, vm_ooffset_t, vm_offset_t *, > > vm_size_t, ^ > > 1 error generated. > > *** [nvidia_subr.o] Error code 1 > >=20 > >=20 > > emulators/virtualbox-ose-kmod: > >=20 > > [...] > > /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-4.2.18/out/fr= eebsd.amd64/release/bin/src/vboxdrv/r0drv/freebsd/alloc-r0drv-freebsd.c:83:= 76: > > error: too few arguments to function call, expected 10, have 9 > > cbAllocated, TRUE, VM_PROT_ALL, VM_PROT_ALL, 0); ^ > > @/vm/vm_map.h:368:1: note: 'vm_map_find' declared here int > > vm_map_find(vm_map_t, vm_object_t, vm_ooffset_t, vm_offset_t *, > > vm_size_t, >=20 > Try the following changes: > int rc =3D vm_map_find(kernel_map, pVmObject, 0, &Addr, > --- cbAllocated, TRUE, VM_PROT_ALL, > VM_PROT_ALL, 0); +++ cbAllocated, 0, > VMFS_OPTIMAL_SPACE, VM_PROT_ALL, VM_PROT_ALL, 0); >=20 > for Nvidia driver need to make similar changes... > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org" The man page of vm_map_find() says the last parameter is of int, named int cow. On the hurry, I didn't find any explanation of that parameter. Setting it to "0" (zero) also in the nvidia_subr.c makes the driver compile again. But simply filling in a int zero is a bit strange without knowing what to do, isn't it? Thanks anyway, Oliver --Sig_/UrICAPLQIU4o8yBNhfpaT_O Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iQEcBAEBAgAGBQJSLjrZAAoJEOgBcD7A/5N8+oYIANdaYd2qOZHiMBOmiYVnNMY9 jYXPUHB+O2CpVAoSPHeAEuzAvl9QfzZ9BMS4NaMPmaVTH8qV3stHX63uI58qAM2f pKmHGzBoOLY+PF9NC3gniwaZQ/8FcseOD8wDtPvvaoxBa8PMHPeXArE/vFyKphEL f+ngRwpTlJw1REElyPPZzB3S86jrnecm9Uy+XhRuD0WziyBrCvpa0CZTxxIM2I68 w/U//34mSBScvibIBLpuA6O7ffQlgTjMHT1dMr+3AgKJNmEFKizbDOxoX22ua8iF EIBX4pRFGgiRUkTTlC4EEc5ODV10dmp0fELcifI5rQfP4osD/Z2deAY536mNH1g= =qouV -----END PGP SIGNATURE----- --Sig_/UrICAPLQIU4o8yBNhfpaT_O--