Date: Tue, 04 Mar 2008 05:09:14 -0200 From: Fernando Gont <fernando@gont.com.ar> To: Mike Silbersack <silby@silby.com> Cc: Rui Paulo <rpaulo@fnop.net>, freebsd-net@freebsd.org Subject: Re: Ephemeral ports patch (fixed) Message-ID: <200803040714.m247EcWT008194@venus.xmundo.net> In-Reply-To: <20080303231459.X43305@odysseus.silby.com> References: <200803030435.m234Z7As026508@venus.xmundo.net> <20080303001004.R37933@odysseus.silby.com> <200803031412.m23EC4WB031100@venus.xmundo.net> <20080303231459.X43305@odysseus.silby.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=====================_1735174625==_ Content-Type: text/plain; charset="us-ascii"; format=flowed At 03:23 a.m. 04/03/2008, Mike Silbersack wrote: >Too optimistic: > >! #define IPPORT_EPHEMERALLAST 655535 > >Otherwise the patch looks good to me. It looked a bit strange in >unified diff format, I needed to look at it in context >format. (Strange, since I usually prefer unified.) Doh! I had fixed this in the patch itself, but then undid that change when I changed the first ephemeral port from 1024 to 10000. This one should be fine. :-) Kind regards, -- Fernando Gont e-mail: fernando@gont.com.ar || fgont@acm.org PGP Fingerprint: 7809 84F5 322E 45C7 F1C9 3945 96EE A9EF D076 FFF1 --=====================_1735174625==_ Content-Type: text/plain; name="patch-port-range.txt"; x-mac-type="42494E41"; x-mac-creator="74747874" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch-port-range.txt" SW5kZXg6IGluLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2hvbWUvbmN2cy9zcmMvc3lzL25ldGlu ZXQvaW4uaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMDAKZGlmZiAtdSAtcjEuMTAwIGluLmgK LS0tIGluLmgJMTIgSnVuIDIwMDcgMTY6MjQ6NTMgLTAwMDAJMS4xMDAKKysrIGluLmgJMSBNYXIg MjAwOCAwOTowMDoxMCAtMDAwMApAQCAtMjkzLDggKzI5Myw3IEBACiAgKgogICogVGhlIHZhbHVl IElQX1BPUlRSQU5HRV9ISUdIIGNoYW5nZXMgdGhlIHJhbmdlIG9mIGNhbmRpZGF0ZSBwb3J0IG51 bWJlcnMKICAqIGludG8gdGhlICJoaWdoIiByYW5nZS4gIFRoZXNlIGFyZSByZXNlcnZlZCBmb3Ig Y2xpZW50IG91dGJvdW5kIGNvbm5lY3Rpb25zCi0gKiB3aGljaCBkbyBub3Qgd2FudCB0byBiZSBm aWx0ZXJlZCBieSBhbnkgZmlyZXdhbGxzLiAgTm90ZSB0aGF0IGJ5IGRlZmF1bHQKLSAqIHRoaXMg aXMgdGhlIHNhbWUgYXMgSVBfUE9SVFJBTkdFX0RFRkFVTFQuCisgKiB3aGljaCBkbyBub3Qgd2Fu dCB0byBiZSBmaWx0ZXJlZCBieSBhbnkgZmlyZXdhbGxzLgogICoKICAqIFRoZSB2YWx1ZSBJUF9Q T1JUUkFOR0VfTE9XIGNoYW5nZXMgdGhlIHJhbmdlIHRvIHRoZSAibG93IiBhcmUKICAqIHRoYXQg aXMgKGJ5IGNvbnZlbnRpb24pIHJlc3RyaWN0ZWQgdG8gcHJpdmlsZWdlZCBwcm9jZXNzZXMuICBU aGlzCkBAIC0zMzEsOCArMzMwLDEzIEBACiAjZGVmaW5lCUlQUE9SVF9SRVNFUlZFRAkJMTAyNAog CiAvKgotICogRGVmYXVsdCBsb2NhbCBwb3J0IHJhbmdlLCB1c2VkIGJ5IGJvdGggSVBfUE9SVFJB TkdFX0RFRkFVTFQKLSAqIGFuZCBJUF9QT1JUUkFOR0VfSElHSC4KKyAqIERlZmF1bHQgbG9jYWwg cG9ydCByYW5nZSwgdXNlZCBieSBJUF9QT1JUUkFOR0VfREVGQVVMVAorICovCisjZGVmaW5lIElQ UE9SVF9FUEhFTUVSQUxGSVJTVAkxMDAwMAorI2RlZmluZSBJUFBPUlRfRVBIRU1FUkFMTEFTVAk2 NTUzNSAKKyAKKy8qCisgKiBEeW5hbWljIHBvcnQgcmFuZ2UsIHVzZWQgYnkgSVBfUE9SVFJBTkdF X0hJR0guCiAgKi8KICNkZWZpbmUJSVBQT1JUX0hJRklSU1RBVVRPCTQ5MTUyCiAjZGVmaW5lCUlQ UE9SVF9ISUxBU1RBVVRPCTY1NTM1CkluZGV4OiBpbl9wY2IuYwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvaG9tZS9uY3ZzL3NyYy9zeXMvbmV0aW5ldC9pbl9wY2IuYyx2CnJldHJpZXZpbmcgcmV2aXNp b24gMS4xOTgKZGlmZiAtdSAtcjEuMTk4IGluX3BjYi5jCi0tLSBpbl9wY2IuYwkyMiBEZWMgMjAw NyAxMDowNjoxMSAtMDAwMAkxLjE5OAorKysgaW5fcGNiLmMJMSBNYXIgMjAwOCAwOTowMDoxMSAt MDAwMApAQCAtODksOCArODksOCBAQAogICovCiBpbnQJaXBwb3J0X2xvd2ZpcnN0YXV0byAgPSBJ UFBPUlRfUkVTRVJWRUQgLSAxOwkvKiAxMDIzICovCiBpbnQJaXBwb3J0X2xvd2xhc3RhdXRvID0g SVBQT1JUX1JFU0VSVkVEU1RBUlQ7CS8qIDYwMCAqLwotaW50CWlwcG9ydF9maXJzdGF1dG8gPSBJ UFBPUlRfSElGSVJTVEFVVE87CQkvKiA0OTE1MiAqLwotaW50CWlwcG9ydF9sYXN0YXV0byAgPSBJ UFBPUlRfSElMQVNUQVVUTzsJCS8qIDY1NTM1ICovCitpbnQJaXBwb3J0X2ZpcnN0YXV0byA9IElQ UE9SVF9FUEhFTUVSQUxGSVJTVDsJLyogMTAwMDAgKi8KK2ludAlpcHBvcnRfbGFzdGF1dG8gID0g SVBQT1JUX0VQSEVNRVJBTExBU1Q7CS8qIDY1NTM1ICovCiBpbnQJaXBwb3J0X2hpZmlyc3RhdXRv ID0gSVBQT1JUX0hJRklSU1RBVVRPOwkvKiA0OTE1MiAqLwogaW50CWlwcG9ydF9oaWxhc3RhdXRv ICA9IElQUE9SVF9ISUxBU1RBVVRPOwkJLyogNjU1MzUgKi8KIApAQCAtMzkzLDcgKzM5Myw3IEBA CiAJaWYgKCpscG9ydHAgIT0gMCkKIAkJbHBvcnQgPSAqbHBvcnRwOwogCWlmIChscG9ydCA9PSAw KSB7Ci0JCXVfc2hvcnQgZmlyc3QsIGxhc3Q7CisJCXVfc2hvcnQgZmlyc3QsIGxhc3QsIGF1eDsK IAkJaW50IGNvdW50OwogCiAJCWlmIChsYWRkci5zX2FkZHIgIT0gSU5BRERSX0FOWSkKQEAgLTQ0 MCw0NyArNDQwLDI4IEBACiAJCS8qCiAJCSAqIFNpbXBsZSBjaGVjayB0byBlbnN1cmUgYWxsIHBv cnRzIGFyZSBub3QgdXNlZCB1cCBjYXVzaW5nCiAJCSAqIGEgZGVhZGxvY2sgaGVyZS4KLQkJICoK LQkJICogV2Ugc3BsaXQgdGhlIHR3byBjYXNlcyAodXAgYW5kIGRvd24pIHNvIHRoYXQgdGhlIGRp cmVjdGlvbgotCQkgKiBpcyBub3QgYmVpbmcgdGVzdGVkIG9uIGVhY2ggcm91bmQgb2YgdGhlIGxv b3AuCiAJCSAqLwogCQlpZiAoZmlyc3QgPiBsYXN0KSB7Ci0JCQkvKgotCQkJICogY291bnRpbmcg ZG93bgotCQkJICovCi0JCQlpZiAoZG9yYW5kb20pCi0JCQkJKmxhc3Rwb3J0ID0gZmlyc3QgLQot CQkJCQkgICAgKGFyYzRyYW5kb20oKSAlIChmaXJzdCAtIGxhc3QpKTsKLQkJCWNvdW50ID0gZmly c3QgLSBsYXN0OworCQkJYXV4ID0gZmlyc3Q7CisJCQlmaXJzdCA9IGxhc3Q7CisJCQlsYXN0ID0g YXV4OworCQl9CiAKLQkJCWRvIHsKLQkJCQlpZiAoY291bnQtLSA8IDApCS8qIGNvbXBsZXRlbHkg dXNlZD8gKi8KLQkJCQkJcmV0dXJuIChFQUREUk5PVEFWQUlMKTsKLQkJCQktLSpsYXN0cG9ydDsK LQkJCQlpZiAoKmxhc3Rwb3J0ID4gZmlyc3QgfHwgKmxhc3Rwb3J0IDwgbGFzdCkKLQkJCQkJKmxh c3Rwb3J0ID0gZmlyc3Q7Ci0JCQkJbHBvcnQgPSBodG9ucygqbGFzdHBvcnQpOwotCQkJfSB3aGls ZSAoaW5fcGNibG9va3VwX2xvY2FsKHBjYmluZm8sIGxhZGRyLCBscG9ydCwKLQkJCSAgICB3aWxk KSk7Ci0JCX0gZWxzZSB7Ci0JCQkvKgotCQkJICogY291bnRpbmcgdXAKLQkJCSAqLwotCQkJaWYg KGRvcmFuZG9tKQotCQkJCSpsYXN0cG9ydCA9IGZpcnN0ICsKLQkJCQkJICAgIChhcmM0cmFuZG9t KCkgJSAobGFzdCAtIGZpcnN0KSk7Ci0JCQljb3VudCA9IGxhc3QgLSBmaXJzdDsKKwkJaWYgKGRv cmFuZG9tKQorCQkJKmxhc3Rwb3J0ID0gZmlyc3QgKworCQkJCSAgICAoYXJjNHJhbmRvbSgpICUg KGxhc3QgLSBmaXJzdCkpOwogCi0JCQlkbyB7Ci0JCQkJaWYgKGNvdW50LS0gPCAwKQkvKiBjb21w bGV0ZWx5IHVzZWQ/ICovCi0JCQkJCXJldHVybiAoRUFERFJOT1RBVkFJTCk7Ci0JCQkJKysqbGFz dHBvcnQ7Ci0JCQkJaWYgKCpsYXN0cG9ydCA8IGZpcnN0IHx8ICpsYXN0cG9ydCA+IGxhc3QpCi0J CQkJCSpsYXN0cG9ydCA9IGZpcnN0OwotCQkJCWxwb3J0ID0gaHRvbnMoKmxhc3Rwb3J0KTsKLQkJ CX0gd2hpbGUgKGluX3BjYmxvb2t1cF9sb2NhbChwY2JpbmZvLCBsYWRkciwgbHBvcnQsCi0JCQkg ICAgd2lsZCkpOwotCQl9CisJCWNvdW50ID0gbGFzdCAtIGZpcnN0OworCisJCWRvIHsKKwkJCWlm IChjb3VudC0tIDwgMCkJLyogY29tcGxldGVseSB1c2VkPyAqLworCQkJCXJldHVybiAoRUFERFJO T1RBVkFJTCk7CisJCQkrKypsYXN0cG9ydDsKKwkJCWlmICgqbGFzdHBvcnQgPCBmaXJzdCB8fCAq bGFzdHBvcnQgPiBsYXN0KQorCQkJCSpsYXN0cG9ydCA9IGZpcnN0OworCQkJbHBvcnQgPSBodG9u cygqbGFzdHBvcnQpOworCQl9IHdoaWxlIChpbl9wY2Jsb29rdXBfbG9jYWwocGNiaW5mbywgbGFk ZHIsIGxwb3J0LAorCQkgICAgd2lsZCkpOwogCX0KIAlpZiAocHJpc29uX2lwKGNyZWQsIDAsICZs YWRkci5zX2FkZHIpKQogCQlyZXR1cm4gKEVJTlZBTCk7Cg== --=====================_1735174625==_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803040714.m247EcWT008194>