From owner-freebsd-fs@FreeBSD.ORG  Fri Nov  7 12:01:22 2014
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id CA0B43C6
 for <freebsd-fs@FreeBSD.org>; Fri,  7 Nov 2014 12:01:22 +0000 (UTC)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 1DEB583D
 for <freebsd-fs@FreeBSD.org>; Fri,  7 Nov 2014 12:01:21 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id OAA25642;
 Fri, 07 Nov 2014 14:03:13 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1XmiEB-000Cab-9I; Fri, 07 Nov 2014 14:01:19 +0200
Message-ID: <545CB43E.6040901@FreeBSD.org>
Date: Fri, 07 Nov 2014 13:59:58 +0200
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Steven Hartland <killing@multiplay.co.uk>, Borja Marcos <borjam@sarenet.es>
Subject: Re: ZFS bug: was creating ZIL ignores vfs.zfs.min_auto_ashift, should
 be ZIL sets improper ashift with AHCI controllers
References: <B731A922-3F83-4D8E-A4EA-22C5CA8A3850@sarenet.es>
 <9C91F97841BC4347910F206618BAA3BB9AF327D1@PAIMAIL.pai.local>
 <545B76EF.6050709@multiplay.co.uk>
 <21D2A3A9-B6C1-458F-B17F-480251E999AE@sarenet.es>
 <545BE3E0.4030203@multiplay.co.uk>
 <757B9039-8DF0-4E6A-A036-82A2143D7F45@sarenet.es>
 <545C9552.30207@multiplay.co.uk>
In-Reply-To: <545C9552.30207@multiplay.co.uk>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: freebsd-fs@FreeBSD.org
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2014 12:01:22 -0000

On 07/11/2014 11:48, Steven Hartland wrote:
> 
> On 07/11/2014 07:31, Borja Marcos wrote:
>> snip...
>>
>> You are right!
>>
>> This time I had not altered min_auto_ashift but I had added a quirk to
>> ata_da.c. So it
>> correctly used the quirk sector size to adjust ashift.
>>
>> Seems the bug should be "improper cache file generation for a pool used for
>> boot". I'll
>> see if I can run some more tests.
>>
> I believe the attached is the correct fix, but I've asked upstream as this test
> was explicitly added ages ago.

It could be that this problem is of no interest / relevance to the illumos
upstream as they have more restrictions on how a root pool can be configured.  I
am not sure if they allow slog devices for root pools.

-- 
Andriy Gapon