From owner-freebsd-current Wed May 28 13:33:26 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id NAA01045 for current-outgoing; Wed, 28 May 1997 13:33:26 -0700 (PDT) Received: from Sisyphos.MI.Uni-Koeln.DE (Sisyphos.MI.Uni-Koeln.DE [134.95.212.10]) by hub.freebsd.org (8.8.5/8.8.5) with SMTP id NAA01040 for ; Wed, 28 May 1997 13:33:21 -0700 (PDT) Received: from x14.mi.uni-koeln.de (annexr2-45.slip.Uni-Koeln.DE) by Sisyphos.MI.Uni-Koeln.DE with SMTP id AA16231 (5.67b/IDA-1.5 for ); Wed, 28 May 1997 22:33:18 +0200 Received: (from se@localhost) by x14.mi.uni-koeln.de (8.8.5/8.6.9) id WAA10835; Wed, 28 May 1997 22:33:18 +0200 (CEST) X-Face: " Date: Wed, 28 May 1997 22:33:17 +0200 From: Stefan Esser To: Tom Jackson Cc: FreeBSD Current Subject: Re: Cur make kernel fails References: <19970528140041.32391@peeper.my.domain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.74 In-Reply-To: <19970528140041.32391@peeper.my.domain>; from Tom Jackson on Wed, May 28, 1997 at 02:00:41PM -0500 Sender: owner-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On May 28, Tom Jackson wrote: > Last good kernel build was ctm2900. Held off until ctm2903 and got this: > > > cc -c -O -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -g -nostdinc -I- -I. -I../.. -I../../../include -DMD5 -DFAILSAFE -DCOMPAT_43 -DMSDOSFS -DFFS -DINET -DKERNEL -include opt_global.h ../../pci/aic7870.c > ..../../pci/aic7870.c: In function `aic7870_attach': > ..../../pci/aic7870.c:344: `PCI_COMMAND_MEM_ENABLE' undeclared (first use this function) > ..../../pci/aic7870.c:344: (Each undeclared identifier is reported only once > ..../../pci/aic7870.c:344: for each function it appears in.) > *** Error code 1 > > Stop. > > Is this a known problem? Sorry, this was an oversight when I replaced the PCI code, two days ago. The test is not necessary anymore, since the functionality is now included in the pci_map_mem() function. Seems I had not tested compiling that driver with AHC_ALLOW_MEMIO defined, which you apparently have. Please apply the following patch to restore the missing define: Index: /sys/pci/pcireg.h =================================================================== RCS file: /usr/cvs/src/sys/pci/pcireg.h,v retrieving revision 1.16 diff -C2 -r1.16 pcireg.h *** pcireg.h 1997/05/28 11:15:18 1.16 --- pcireg.h 1997/05/28 20:28:54 *************** *** 238,241 **** --- 238,242 ---- #define PCI_COMMAND_STATUS_REG 0x04 #define PCI_COMMAND_IO_ENABLE 0x00000001 + #define PCI_COMMAND_MEM_ENABLE 0x00000002 #define PCI_CLASS_REG 0x08 #define PCI_CLASS_MASK 0xff000000 Thanks for reporting the problem! Regards, STefan