From owner-svn-src-head@freebsd.org Sat May 19 15:50:57 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 51D66EB1745 for ; Sat, 19 May 2018 15:50:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D3D9C73F11 for ; Sat, 19 May 2018 15:50:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x242.google.com with SMTP id y189-v6so16666435itb.2 for ; Sat, 19 May 2018 08:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=e98AQo9/u5zDtp36kcxqJxvoSZqco8b6Q48NFPuK/qc=; b=omTm6R0OqOj3dcYA+agES4Da1Qav24I5empQQOLJp8UhR8nhShMLyFIprl2jdNjz7w CZ5YIkgiSODqODARRjt4XQEoY6JZQdMwh+MRngEcBkxb4WRIrjB7zF1aGHfrFqnLeBMs 42tY7efNN+Zz+/sXACk7XhMH8t3d6/jtt/q7C+4M2I78CKBnoYgGJCszQxo1sUWN9sIh 6u7OlD38R/H9XaVmztnUKuhbNZdT1iGRV52p3Q1ckTt+w+Mlqp96aGnjiH+sfxEuJPDP rsaGXC4ek+ec28EAd4NxjSPyYuQrK3eVnrFr812GI0Si6uuEWk3ivLfvsDR2mcANDxpC /vHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=e98AQo9/u5zDtp36kcxqJxvoSZqco8b6Q48NFPuK/qc=; b=bF0wftvAOJZtHpQgmQO0JWfaVGQ1crTxmgYHCQIwTbAtBT6JFRx2u9+4sPC77uRgeX 2BgV4ZjHk8xP1H4WpGTvUE80S1TBWrgzo2rLHNuLOpaboFMjGyRTtFo4Hc69dnTDmcWM 1LhVd6bJV7L+V8LB4BxCXD2q0DmWY+LlWbDBYgjyIHvRpLVmou3wi5K8+zbffyWyY7Xb 02kqG0DLsU6vDKNqdW1zxrvp/ckzKI/f9AKUyzMOrSCMejjjp12Sm7C7MLd0HVbPw++2 MLqioGDCZtkLY0RSN3NOlz12MD3aVLqHnHzaZlcsy9oD2U0UTfv782Y3StEnpWWtcqJB JBZQ== X-Gm-Message-State: ALKqPwc6/FSsM0CnncEvUB8H5/unf9LsH9FT1YxzQGOSB8aFBThc1ve9 avHXMa2+tqL3f0Jex4wCFREf4hbbv0p9WpjUImKrcw== X-Google-Smtp-Source: AB8JxZoinp4RUOJ0Jj3brNR/9jA2qc+ZA/xR+GdGW8/2BzkW3+YTAe4vR2WZW+yAvtLB9QkLhg2tU+hN/nXvRtShTrc= X-Received: by 2002:a24:4c55:: with SMTP id a82-v6mr11200426itb.1.1526745056239; Sat, 19 May 2018 08:50:56 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:a649:0:0:0:0:0 with HTTP; Sat, 19 May 2018 08:50:55 -0700 (PDT) X-Originating-IP: [172.58.56.82] In-Reply-To: References: <201805191335.w4JDZq9b015979@pdx.rh.CN85.dnsmgr.net> <29252c55ea65fe53b9ab4e673ec6726c@megadrive.org> From: Warner Losh Date: Sat, 19 May 2018 09:50:55 -0600 X-Google-Sender-Auth: bOSeiZdDSn2-BREvDTSGvGhOEWg Message-ID: Subject: Re: svn commit: r333822 - head/sys/kern To: Matthew Macy Cc: Emmanuel Vadot , owner-src-committers@freebsd.org, "Rodney W. Grimes" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2018 15:50:57 -0000 On Sat, May 19, 2018 at 9:48 AM, Warner Losh wrote: > > > On Sat, May 19, 2018 at 9:39 AM, Matthew Macy wrote: > >> >> On Sat, May 19, 2018 at 07:17 Emmanuel Vadot >> wrote: >> >>> On 2018-05-19 15:35, Rodney W. Grimes wrote: >>> > [ Charset UTF-8 unsupported, converting... ] >>> >> Author: mmacy >>> >> Date: Sat May 19 02:15:40 2018 >>> >> New Revision: 333822 >>> >> URL: https://svnweb.freebsd.org/changeset/base/333822 >>> >> >>> >> Log: >>> >> fix gcc8 unused variable and set but not used variable in unix >>> >> sockets >>> >> add copyright from lock rewrite while here >>> >> >>> >> Modified: >>> >> head/sys/kern/uipc_usrreq.c >>> >> >>> >> Modified: head/sys/kern/uipc_usrreq.c >>> >> ============================================================ >>> ================== >>> >> --- head/sys/kern/uipc_usrreq.c Sat May 19 00:47:24 2018 >>> (r333821) >>> >> +++ head/sys/kern/uipc_usrreq.c Sat May 19 02:15:40 2018 >>> (r333822) >>> >> @@ -4,7 +4,7 @@ >>> >> * Copyright (c) 1982, 1986, 1989, 1991, 1993 >>> >> * The Regents of the University of California. >>> >> * Copyright (c) 2004-2009 Robert N. M. Watson >>> >> - * All rights reserved. >>> > >>> > Did you have permission from Robert Watson to remove this? >>> > >>> >> + * Copyright (c) 2018 Matthew Macy >>> >> * >>> >> * Redistribution and use in source and binary forms, with or without >>> >> * modification, are permitted provided that the following conditions >>> > ... >>> >>> That also seems a small patch to add your name in the copyright. >>> >> >> Uhh... Locking rewrite was a small patch? Really? >> > > This specific change was trivial. However, rewriting the locking here was > non-trivial. The normal rule of thumb is about 25%, but that's flexible. > mmacy is responsible for about 14% of the file according to git blame (a > number that would be closer to 20% if you omitted the boilerplate parts of > the file). If all his changes were trivial variable initializations, then > I'd agree this fall short. But the new locking stuff is substantial enough > to meet our traditional requirements for adding a copyright line. It > affects the majority of the files and is a core functional feature of this > file. > Sigh... s/affects the majority of the files/affects the majority of the functions in this file/ Normally I wouldn't make this small a correction, but i materially affects my argument. Warner