From owner-freebsd-geom@FreeBSD.ORG Mon Mar 15 10:52:48 2010 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2DB571065670; Mon, 15 Mar 2010 10:52:48 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello089077043238.chello.pl [89.77.43.238]) by mx1.freebsd.org (Postfix) with ESMTP id 5E2D68FC24; Mon, 15 Mar 2010 10:52:46 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id DC22945EC0; Mon, 15 Mar 2010 11:52:41 +0100 (CET) Received: from localhost (pdawidek.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id ED6FD45DD8; Mon, 15 Mar 2010 11:52:37 +0100 (CET) Date: Mon, 15 Mar 2010 11:52:38 +0100 From: Pawel Jakub Dawidek To: Jaakko Heinonen Message-ID: <20100315105238.GB3103@garage.freebsd.pl> References: <20100313083551.GB966@a91-153-117-195.elisa-laajakaista.fi> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BwCQnh7xodEAoBMC" Content-Disposition: inline In-Reply-To: <20100313083551.GB966@a91-153-117-195.elisa-laajakaista.fi> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: phk@FreeBSD.org, freebsd-geom@FreeBSD.org Subject: Re: Escape unsafe characters for kern.geom.confxml XML dump X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2010 10:52:48 -0000 --BwCQnh7xodEAoBMC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 13, 2010 at 10:35:52AM +0200, Jaakko Heinonen wrote: >=20 > Hi, >=20 > I intend to commit following patch unless there are objections. I have > seen the problem commonly reported by FreeBSD users. >=20 > --- >=20 > Escape characters unsafe for XML output in GEOM class, instance and provi= der > names. >=20 > - Characters in range 0x01-0x1f except '\t', '\n', and '\r' are replaced > with '?'. Those characters are disallowed in XML. > - '&', '<', '>', '\'', '"' and characters in range 0x7f-0xff are replaced > with XML numeric character reference. >=20 > If the kern.geom.confxml sysctl provides invalid XML, libgeom > geom_xml2tree() fails and utilities using it do not work. Unsafe > characters are common in msdosfs and cd9660 labels. >=20 > PR: kern/104389 > Submitter by: Doug Steinwand (original version) Patch looks good and it was something missing for a very long time. Thanks for taking care of this. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --BwCQnh7xodEAoBMC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkueEXYACgkQForvXbEpPzSSaQCfeAQqgpMMJgAzkcp6A26L1/hC QBgAoKxG6UlrBrpnGYQB8snl5mAxaVtI =qDvd -----END PGP SIGNATURE----- --BwCQnh7xodEAoBMC--