Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Mar 2023 20:05:59 -0400
From:      Mark Johnston <markj@freebsd.org>
To:        Kristof Provost <kp@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: b60600ceeb68 - main - pf tests: Serialize
Message-ID:  <ZCYj50rKEtzIgqc0@nuc>
In-Reply-To: <3A26AB82-357F-421F-853E-07320387ACBE@FreeBSD.org>
References:  <202303302336.32UNatba067594@gitrepo.freebsd.org> <3A26AB82-357F-421F-853E-07320387ACBE@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 31, 2023 at 08:56:56AM +0900, Kristof Provost wrote:
> On 31 Mar 2023, at 8:36, Mark Johnston wrote:
> > The branch main has been updated by markj:
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=b60600ceeb68d1001d61222830e0be3441ef0885
> >
> > commit b60600ceeb68d1001d61222830e0be3441ef0885
> > Author:     Mark Johnston <markj@FreeBSD.org>
> > AuthorDate: 2023-03-25 12:55:41 +0000
> > Commit:     Mark Johnston <markj@FreeBSD.org>
> > CommitDate: 2023-03-30 23:35:59 +0000
> >
> >     pf tests: Serialize
> >
> >     These tests reuse jail names and cannot run in parallel.  Until this is
> >     fixed - which is desirable since these takes take a while to run - tell
> >     kyua to serialize them.
> >
> 
> The tests also recycle IP ranges, so merely changing the jail names is insufficient.

Could you please give an example?  I looked at some of the tests but can
only see cases where addresses are assigned within the vnet jail(s)
created by the tests, in which case I'd expect no problems.

> Realistically the easiest way to get these to run in parallel would be to run each test in its own vnet so both overlapping IP ranges and name conflicts don’t matter.

Yeah, I was wondering whether it'd be possible to have kyua handle the
creation and teardown of a per-test jail, if only to avoid having to go
through all of the tests which use static jail names.  Though at the
moment I'm more focused on getting the test suite to run cleanly with
parallelism enabled before I try to make it run faster.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZCYj50rKEtzIgqc0>