From nobody Fri Apr 11 13:56:22 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZYys51bH3z5s3WV; Fri, 11 Apr 2025 13:56:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZYys46kZ0z41BT; Fri, 11 Apr 2025 13:56:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744379785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9eZSKYUIk51tVALBY5to1oua4Yx/BEajRXbW635X1ik=; b=Tige7jADY0DTvCkCfFSMwhqtiZWUo0Im7fuGOjgUxDhwKWV+wdw08R2nz9npjgNYTvmeyO cJGCPuyALSMMdgOtQl5NDed9+p9ZCuHKdE6VVj2s3byZgXYnLaeA7pleKGtyIYz3A8x52o z1HcD883KzqNEl1cFJDJYP9RpK89RGMrFKQN+wRxXmZ6BFUN0n1X1oJQ+OYy0YkEMg2C0S Qn68Q9PIwQbwOLKZFYs1hPNsqmGZPmM9cOgbstWAYYP3tYKBMaxaUNFSFNjHO6I1y6wQ/i udogvL1dtkOEyR1dBBGGirp0nyq6D9qe9osV2v3zB/03+nUUIwieawzizH09FQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744379785; a=rsa-sha256; cv=none; b=dFUFSQTTO7QabYNQgfxgNBvK9vLrRttoqtZZZPORNtrk6c4YwhbxIxQilG0OJpF9OVDxs5 ic4/J7RWD94c0ABW1hZXFPsxGAoa9muAppPYoyvEFnAoFIgZ1Azx9ElVKjJTqYbT4otsW8 bKmW2BtNzSLR74WsvIRRebJU0UTJoKzc0eylZX+wc9fwWr49e1tZB47XoOL8RssKzhFYpR t5hvzg+EtFDLKRt+/6CfTPjhm0DimoLAvu/Tr7cVo9J0DGMYKZPZakQ9qAG+W0uc3JunHb AQR5M/om0NM9SzkjeZ9kSPByoM3EEnPa4m1JLnSpjyyuCiql7rnoNFNF5NXAQQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744379785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9eZSKYUIk51tVALBY5to1oua4Yx/BEajRXbW635X1ik=; b=W8heUoODW7KcaP5bkvB/SUr4kKsWlC8kWDZRtUo7rQ8Xt3aw7bWp2FKz20ukctJ5SptF83 kW8UvGTGVcnDZnHZ9rWQop5UWuqgPEEThHDSPnIt0zy/jampgQqMdbLDipWBkifUJ96+6M CCr4WhZymQYvcn/4U+knL6Trvk/fuQqhVJJaOF0cmuWLwApBmi8ZuhDvUUzh4WdFITW+uW 82CzYdQy5R+sfheZk+OkMwOrintdzrogvYSrfEeYi8c98BapEfDEezhSnoAShwvxlxpG4J lxaUCODX78o5Lmd7PzABNdDGuYALd9Y7k8l1x7r3SSm2HCGllkprTqrNOXc2RQ== Received: from [IPV6:2601:5c0:4200:b830:ec3d:c0fe:c8c9:13aa] (unknown [IPv6:2601:5c0:4200:b830:ec3d:c0fe:c8c9:13aa]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZYys44Gb1zG8H; Fri, 11 Apr 2025 13:56:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <0349dcb7-2466-4c6a-bc40-e8405ef52ef6@FreeBSD.org> Date: Fri, 11 Apr 2025 09:56:22 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 75a24e7f9afb - main - ctld: Disable -Wshadow for GCC Content-Language: en-US From: John Baldwin To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202504111352.53BDqrmc033812@gitrepo.freebsd.org> In-Reply-To: <202504111352.53BDqrmc033812@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/11/25 09:52, John Baldwin wrote: > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=75a24e7f9afb128138c3b3462b80731cab0f5bdd > > commit 75a24e7f9afb128138c3b3462b80731cab0f5bdd > Author: John Baldwin > AuthorDate: 2025-04-11 13:34:36 +0000 > Commit: John Baldwin > CommitDate: 2025-04-11 13:52:39 +0000 > > ctld: Disable -Wshadow for GCC > > GCC raises shadow warnings in C++ when a global function shadows a > structure type name (since it shadows the constructors for that type). > System headers are full of such cases (and some such as struct sigaction > vs sigaction() are mandated by POSIX), so just disable the warning. > > For example: > > In file included from usr.sbin/ctld/ctld.cc:33: > sys/sys/event.h:366:20: error: 'int kqueue()' hides constructor for 'struct kqueue' [-Werror=shadow] > 366 | int kqueue(void); > | ^ > sys/sys/event.h:371:43: error: 'int kevent(int, const kevent*, int, kevent*, int, const timespec*)' hides constructor for 'struct kevent' [-Werror=shadow] > 371 | const struct timespec *timeout); > | ^ > In file included from usr.sbin/ctld/ctld.cc:37: > sys/sys/stat.h:396:63: error: 'int stat(const char*, stat*)' hides constructor for 'struct stat' [-Werror=shadow] > 396 | int stat(const char * __restrict, struct stat * __restrict); > | ^ > > Reported by: bz > --- > usr.sbin/ctld/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/usr.sbin/ctld/Makefile b/usr.sbin/ctld/Makefile > index f96f3152e061..79c69c95fbb1 100644 > --- a/usr.sbin/ctld/Makefile > +++ b/usr.sbin/ctld/Makefile > @@ -14,6 +14,7 @@ CFLAGS+= -I${SRCTOP}/sys/dev/iscsi > CFLAGS+= -I${SRCTOP}/lib/libiscsiutil > #CFLAGS+= -DICL_KERNEL_PROXY > NO_WCAST_ALIGN= > +CXXWARNFLAGS.gcc= -Wno-shadow > MAN= ctld.8 ctl.conf.5 > > LIBADD= bsdxml iscsiutil md sbuf util ucl m nv Possibly we should disable -Wshadow globally for GCC for C++ in bsd.sys.mk. -- John Baldwin