From owner-dev-commits-src-all@freebsd.org Sun Apr 18 08:30:27 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 01E4A5E08B8; Sun, 18 Apr 2021 08:30:27 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2043.outbound.protection.outlook.com [40.107.101.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FNNRz4pQbz4tXg; Sun, 18 Apr 2021 08:30:23 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W6dYr+Gz46NB36ijbjdCGNG1PgWT7SWZ3pBN2HY6Z8ytS/bDX3oqjAMeInotWT/Kjd4WU/TrnSuCtq/f39zXbMyUKJaNwI2Xnn7ELOmn2ZZjrgZlDWq4anqInCg7EFVf0r6VBay3YFw9EWrXuIMb27ut9XOfuXtAW6oLgUn/BogyHUvlUci6j6S039U1qCYwQIKACEtzJiZL0cLraN2mTiYyK02etjdcxi3zrf153NC78CCL1zOS8AJxFate7Tsw6etkeg6w0rCb7RcAp7Asv5iGetRamrPx/kasTvjwxO/wzyqGKUp/YEHt05pX3Klc+BbkIP23RwLi/j8rmGRWRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=19Y8fiBsM3HdiuoHBurDy8SgjzO8icDgQzjO1PGKFeg=; b=ZvSL6WyDjc6rt5s5JJezhAl0Y8SXXBZm3oyNCnt/vpH/v0KdQNTN29Xb0UJYK7PGmbu7V3SifqKOznDk6zyWvihtZXPBzyV9ZUk+PJj4D+7FeZ53oPv2ldBLN6j+mtFaKk6TpSwKWvTdMJQ/3wybnBNuLtZ0SoO7tp+alN4myPrHQxUa64Xk83Zh0JaKaHldxIQ5iDbg94AdXHrb5gplmruIGOAsmRYo1xKYleAlgEQ7Z7uVCkQShCcT8YJRmKhR3ijNyBY2hYbYjC6kVgzgNbyjFgPYl3EpXo3J/wl8bHT7EbNkecoGFWQUT/BwDwh+oiMUDkIyr1ew9ljLOfGJKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=netapp.com; dmarc=pass action=none header.from=netapp.com; dkim=pass header.d=netapp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netapp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=19Y8fiBsM3HdiuoHBurDy8SgjzO8icDgQzjO1PGKFeg=; b=2d8j5yxsAVX8Gnz6+hff1Lqlm/g78jm+qiGOhcOHnnCY3rNQqB9trAi9xx1sUL0ctunG10r2OfRJAcgCrVA8qFx4SJA/H+uQxnjdL86BMVdcQyEQlgy85iWzg+uYMr6suovM6k0ZJiphKt/CNTaFS4VWV4YHtFuVAUMOyLK0k26vb4AyDX/ksCz+fXzKAkjAzqf9p1jgEnNK7emfsGSkJkWyM/fZi3my0z0FndwYXCcKkwgbZOlru4+2z0wJi3cI3fXFK5KoX6PrapX2dFXxeZQjCmhZZnqlO3AgZ0ZjucJiGVK6lh+anZ669Umt3ErrSORyH4U76pSWqkhK6N/Tng== Received: from PH0PR06MB7639.namprd06.prod.outlook.com (2603:10b6:510:4e::18) by PH0PR06MB7112.namprd06.prod.outlook.com (2603:10b6:510::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Sun, 18 Apr 2021 08:30:21 +0000 Received: from PH0PR06MB7639.namprd06.prod.outlook.com ([fe80::19e2:b5f4:2a64:5eda]) by PH0PR06MB7639.namprd06.prod.outlook.com ([fe80::19e2:b5f4:2a64:5eda%5]) with mapi id 15.20.4042.024; Sun, 18 Apr 2021 08:30:21 +0000 From: "Scheffenegger, Richard" To: Peter Holm , Richard Scheffenegger CC: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , "transport@freebsd.org" Subject: AW: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default Thread-Topic: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default Thread-Index: AQHXM5CiCqQV41lYIEC3c4/iyC2cxKq5yTAAgAAndzA= Date: Sun, 18 Apr 2021 08:30:20 +0000 Message-ID: References: <202104171350.13HDoPQL025776@gitrepo.freebsd.org> <20210418060040.GA48834@x8.osted.lan> In-Reply-To: <20210418060040.GA48834@x8.osted.lan> Accept-Language: de-AT, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [185.236.167.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1fa443e6-db3e-46eb-ba97-08d902443480 x-ms-traffictypediagnostic: PH0PR06MB7112: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YahJPfNH2o1DrM6SGsxyHJPJg5gdW3jaRLjh3NJRKcrLsnSu93bxQ7QAiM9zmWug7a3HQ4aJ8LS0BxUr1uSJ/kG95cGL9Ufp9o3qHgIx8LFiWelYiEsS4ty1pAKqyYy16qvYOrBfVWWI83ri6K+yBlDEUd8vXU96mrVhTXTDCuiSTYxADZltED7K7fOFiSXWHK66TS5DhClscuVty1gC9N40WhB/o5diVMV2Sw/a+9QnAKMnFUfDHarDnqMV1VKon9rgfFWXr5w4zzpgQqVeWfoRUk0oouxeTh2+epee3hnjXPvjZVOxj3xIIgLPIMw5tYXvdkF1XTNKOmEjsrdXIrEN4/DAVxpJ4FPnvpxqKf1Ifp2t52CXqH2WNyT43fm925KuTV70wnArpBusV8+jHDL2F143DQtxn3TphheG5Dfq1/hwgABEaS8y8F+W/psUMcsJQuKdgTSiMH0kBIUjnf3f+9Pog8QWZ45talbiWgdXI2AFaQeB28a0q+G/Y0ziAC2H8BPFz5h7kSfD5DZSH2TlT2opGb+E7hwnGCgRlsue93zlzJGzJbfUlM9G2VKCfFkbxYmfNcfw3cMOLiVJLbuAmNLDVQpYEWob+MPHKvWAwYeBQCtQ03nmxOW3B/QdRDvedMsqbDQV7q3jzfT5kXXxyB4lLAr+eQXPT+cV9jjqs+FKpGj4EPtj+qpez1lP x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR06MB7639.namprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(366004)(136003)(376002)(396003)(83380400001)(66574015)(4326008)(478600001)(450100002)(2906002)(66476007)(66946007)(66446008)(5660300002)(76116006)(6506007)(966005)(55016002)(33656002)(66556008)(9686003)(64756008)(54906003)(7696005)(52536014)(86362001)(38100700002)(186003)(71200400001)(122000001)(8936002)(316002)(8676002)(26005)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?/k/FACsa2+s9wyFXnDJkNw6Cwo/IgbnL0k+rTxAUIV9XXVY/dN+1m18jIk?= =?iso-8859-1?Q?FfsAEMYdG3bc/PeqBE9SAnDLrFDKJgvVkxE2IB1zS8e86ksM9Oo88+UDVJ?= =?iso-8859-1?Q?3pLpbrKqKT9vceZP7j7N0VznggiFFfBG3LxRVLOUbnLwDye6b43d73MFz9?= =?iso-8859-1?Q?QSnBXJKFZcAsCWgJQJqNB4bBq3+yL66A/2p2rY+jKT80VUPZ82OKilr+MV?= =?iso-8859-1?Q?QHwbZ/tbLsiIbOz+9mAv+Ywb5hGzP0OKywALNbmtfaCP1Lr7dAvWekCLe7?= =?iso-8859-1?Q?ucsAjb0vVogqpS2V/5kIvOzGdDDDsVWykMwWd/enZZA5fKcD/vJnOEfBKZ?= =?iso-8859-1?Q?QUHlW5I6dxdoVjffW+QLzFal5Z/I5uFa4wR/vyneatChnVvoZibvBfGT3+?= =?iso-8859-1?Q?+FZoyIGcUzynN7E8e1+nuUBb4SLQujoVU4V1eQMsPjA5lOWJ0jMhr2rnTv?= =?iso-8859-1?Q?casFXAk0gbpRLkumtWzqfBxX+DsxJO1Bn+EDVk9bix++CjAUmmO5Vg3NKk?= =?iso-8859-1?Q?XrdBN5DxOmSXFeLYk+plp9YG7MDcZYck+Rs1v8hOC+rbYqxMkZ/G4vdBDg?= =?iso-8859-1?Q?p+X4MzCUlgrjddt/rodAoXGtz+XRZSkVCOx4z5M31jMO1LJdNxi5PaN2TC?= =?iso-8859-1?Q?Zew/x60+vLQdcejpF9BkvR9f57V+Swu9FViWPxngBLTkXtCYq0IZ0jGUTT?= =?iso-8859-1?Q?uqFY25i2pusgy+zoHC+TSp7aw/8tHRSL4VBP8rpA4R7E/+gJCdxujt/myc?= =?iso-8859-1?Q?NLTsAWN8hVFVZgvCFB2RnzIL6OeqpEMcQsu45cyDYOQ0S5r7peK2PHGyFA?= =?iso-8859-1?Q?ap2vG4MPgOx4czCWgoXOFWjNp21QZBIJXdOEGR4VjHgBqWzm1C+NSmgEnD?= =?iso-8859-1?Q?TSSjqD4zk9LVvYs/5S/7TyqFWo6qIemBZMuX35UiEeKg/0NEju6+BlevDG?= =?iso-8859-1?Q?zXG45Yh0DflT9/ujG39SCVaphg40C+SLNm84nGblI7H+kfeF8R6bZQn0V0?= =?iso-8859-1?Q?gAVFLi2ZDSgWjQaeMX28dp8eBDAMASYHzST0XQ9gCTc0dS6Z++ky78Jy88?= =?iso-8859-1?Q?gubW02jWCo9obSxcbBWhXhhB76oWLN6rswH4sGQMChC4HBdCrBGxGtbY75?= =?iso-8859-1?Q?r2WA90eyyktc43+JL86YMd1Yuj2FCZXzWkdWsInY2BjlxdVja1P21H9A62?= =?iso-8859-1?Q?rjU5FQRkaPs+dNlHLtO4Ut/ppqyAt23lOt0pC4mW0R857Mhl49WhoSLv81?= =?iso-8859-1?Q?8mK46Idg1eKtmXHjyK327ElUsLfhK9ePfGr0qas1w/cPMuKdBb6h+hxZsi?= =?iso-8859-1?Q?DsbUVc9Kbfk5jmle/7UZGFoy9EoGYRBS8QXEkVm0btisYUwTC8MHnLXjfj?= =?iso-8859-1?Q?qiEiviS3Y1?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: netapp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR06MB7639.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fa443e6-db3e-46eb-ba97-08d902443480 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2021 08:30:20.9687 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4b0911a0-929b-4715-944b-c03745165b3a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GQ45CsIMXtxESiOfjovGgUbWPkEyMp+AfAynmklthFAz6PTPeXpyyceRaX8F679XKHWBv/Smkk6+ztwylgwW0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR06MB7112 X-Rspamd-Queue-Id: 4FNNRz4pQbz4tXg X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 08:30:27 -0000 Hi Peter, Hmm... the panic appears to be due to a stale entry in the sack scoreboard = - a hole not having been closed up to snd_una... Unlikely that this was solely due to this change by itself. Can I get the vmcore and kernel.debug for a close investigation? Richard Scheffenegger -----Urspr=FCngliche Nachricht----- Von: Peter Holm =20 Gesendet: Sonntag, 18. April 2021 08:01 An: Richard Scheffenegger Cc: src-committers@freebsd.org; dev-commits-src-all@freebsd.org; dev-commit= s-src-main@freebsd.org Betreff: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.re= vised, and enable by default NetApp Security WARNING: This is an external email. Do not click links or o= pen attachments unless you recognize the sender and know the content is saf= e. On Sat, Apr 17, 2021 at 01:50:25PM +0000, Richard Scheffenegger wrote: > The branch main has been updated by rscheff: > > URL:=20 > https://cgit.FreeBSD.org/src/commit/?id=3Dd1de2b05a001d3d80f633f576f4909 > c2686dda3d > > commit d1de2b05a001d3d80f633f576f4909c2686dda3d > Author: Richard Scheffenegger > AuthorDate: 2021-04-17 12:59:30 +0000 > Commit: Richard Scheffenegger > CommitDate: 2021-04-17 12:59:45 +0000 > > tcp: Rename rfc6675_pipe to sack.revised, and enable by default > > As full support of RFC6675 is in place, deprecating > net.inet.tcp.rfc6675_pipe and enabling by default > net.inet.tcp.sack.revised. > > Reviewed By: #transport, kbowling, rrs > Sponsored by: NetApp, Inc. > Differential Revision: https://reviews.freebsd.org/D28702 > --- > share/man/man4/tcp.4 | 25 ++++++++++++++----------- > sys/netinet/cc/cc_cubic.c | 2 +- > sys/netinet/cc/cc_htcp.c | 2 +- > sys/netinet/cc/cc_newreno.c | 2 +- > sys/netinet/tcp_input.c | 11 +++-------- > sys/netinet/tcp_sack.c | 12 +++++++++--- > sys/netinet/tcp_var.h | 4 ++-- > 7 files changed, 31 insertions(+), 27 deletions(-) > > diff --git a/share/man/man4/tcp.4 b/share/man/man4/tcp.4 index=20 > d01505e58427..cbb8021226fe 100644 > --- a/share/man/man4/tcp.4 Could this panic be related? 20210418 07:19:59 all (204/751): jumbo.sh panic: tcp_output: sack block to the left of una : -293976 cpuid =3D 3 time= =3D 1618723234 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00e49b0= 550 vpanic() at vpanic+0x181/frame 0xfffffe00e49b05a0 panic() at panic+0x43/frame 0xfffffe00e49b0600 tcp_output() at tcp_output+0x27dc/frame 0xfffffe00e49b07c0 tcp_do_segment() at tcp_do_segment+0x32a3/frame 0xfffffe00e49b08b0 tcp_input() at tcp_input+0xbd5/frame 0xfffffe00e49b0a10 ip_input() at ip_input+0x194/frame 0xfffffe00e49b0aa0 swi_net() at swi_net+0x1a1/frame 0xfffffe00e49b0b20 ithread_loop() at ithread_loop+0x279/frame 0xfffffe00e49b0bb0 fork_exit() at fork_exit+0x80/frame 0xfffffe00e49b0bf0 fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00e49b0bf0 --- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 --- https://people.freebsd.org/~pho/stress/log/log0094.txt - Peter