From owner-svn-ports-all@freebsd.org  Wed Oct 23 12:50:11 2019
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 928DB151940;
 Wed, 23 Oct 2019 12:50:11 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 46yqwM2tzJz44lT;
 Wed, 23 Oct 2019 12:50:11 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 5C53C11614; Wed, 23 Oct 2019 12:50:11 +0000 (UTC)
Date: Wed, 23 Oct 2019 12:50:11 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Tobias Kortkamp <tobik@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r515252 - head/x11/cool-retro-term
Message-ID: <20191023125011.GA89792@FreeBSD.org>
References: <201910231211.x9NCBOf2070687@repo.freebsd.org>
 <20191023124302.GA64150@urd.tobik.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191023124302.GA64150@urd.tobik.me>
User-Agent: Mutt/1.11.4 (2019-03-13)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Oct 2019 12:50:11 -0000

On Wed, Oct 23, 2019 at 02:43:02PM +0200, Tobias Kortkamp wrote:
> On Wed, Oct 23, 2019 at 12:11:24PM +0000, Alexey Dokuchaev wrote:
> > New Revision: 515252
> > URL: https://svnweb.freebsd.org/changeset/ports/515252
> > 
> > Log:
> >   - Switch to USES+=compiler:c++11-lang to unbreak on PowerPC instead
> >     of the approach taken in r513793 (Clang was never required for this
> >     port, any not-so-ancient compiler would suffice)
> >   - Sort the values on the USES list; avoid hardcoding version numbers
> > [...]
> > @@ -16,24 +16,15 @@ GH_ACCOUNT=	Swordfish90
> >  GH_PROJECT=	qmltermwidget:qtw
> >  GH_TAGNAME=	0.2.0:qtw
> > [...]
> >  post-extract:
> >  	@${RMDIR} ${WRKSRC}/qmltermwidget
> > -	@${LN} -s ../qmltermwidget-0.2.0 ${WRKSRC}/qmltermwidget
> > +	@${LN} -s ../qmltermwidget-${GH_TAGNAME_qtw} ${WRKSRC}/qmltermwidget
> 
> This is very complicated

Not true. :)

> and unnecessary.

That's true.

> post-extract should be removed and replaced with
> GH_SUBDIR=	qmltermwidget:qtw

Yeah, I know; AFAIR I've ported this before we had multi-repo (external
references) support in the framework and never converted.  I can do that
if you insist.

./danfe