From owner-cvs-src@FreeBSD.ORG Mon Feb 23 08:09:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8306F16A4CE; Mon, 23 Feb 2004 08:09:55 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 26E8143D1D; Mon, 23 Feb 2004 08:09:55 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.10/8.12.9) with ESMTP id i1NG9skj030617; Mon, 23 Feb 2004 09:09:54 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 23 Feb 2004 09:09:22 -0700 (MST) Message-Id: <20040223.090922.112923872.imp@bsdimp.com> To: scottl@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <403A22BB.6010409@freebsd.org> References: <8758.1077551092@critter.freebsd.dk> <403A22BB.6010409@freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha mem.c promcons.c src/sys/alpha/tlsb zs_tlsb.c src/sys/amd64/amd64 mem.c src/sys/cam cam_xpt.c src/sys/cam/scsi scsi_ch.c scsi_pass.c scsi_pt.c s X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Feb 2004 16:09:55 -0000 In message: <403A22BB.6010409@freebsd.org> Scott Long writes: : I agree with these arguments. However, I would have liked to have seen : a small grace period defined, especially since people are now bumping : into the consequences of this change and not knowing why. I plan to do : this with the interrupt API change when it comes. Especially since the code to do this is on the order of: if (devsw->d_version == 0) { printf("Warning, older interface ..."); devsw->d_flags ^= D_NEEDGIANT; devsw->d_version = D_VERSION_00; } unless there are other issues not elucidated (I'm only looking at the new code). One could also have had two different bits so APIly it changed, but you could whine if only one of them was set. Warner