From owner-svn-src-head@freebsd.org Sat Jul 21 16:41:52 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05D211050221; Sat, 21 Jul 2018 16:41:52 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 56A078F890; Sat, 21 Jul 2018 16:41:51 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-x241.google.com with SMTP id j19-v6so13534535ljc.7; Sat, 21 Jul 2018 09:41:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=/pC/1KMOzoeqg6MW7sfbMXFBzbF3/e9rFlh5sdCCohU=; b=MOVTxi1WA65C/Z8PDotRAQV8pDxkx461U9aI3UeNMPly6roDe6dqivLqVvohhZFlL4 Uwstsw0RxxFXjI3cqdd0eaoqhggFhQ0wtv8Y6VmA/zHTaDm9IHmfNwNkA4a17g0/Tq+K JDsUi0/ija0z/bRE4LYT0Qs7oLPhK2IrFXZfnw4m6Gud30LagepvxZIjR8WhDML20irr Y3JMd9e/2cU3DGqPGSr0rAu7K6uuEK/PSIS8D0veZj9yWNiiE1RAKL0eeW4B+U/C8POJ YGN06OJdCkZ5oO0Rj3DjHgLAsQtHT9pTV+o2NSciRSwld2NhMhIpmjBnH+lzfhctRKUI lpiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=/pC/1KMOzoeqg6MW7sfbMXFBzbF3/e9rFlh5sdCCohU=; b=rtKmN4p41e2cVRWhJA5z4e8FwI8BZwrWPsqZPWGLulkL7pPSkALZiqIEnYe0YlpnFG UBUUJgCkntvQffVSIlS9H8MZcivgjnLw3IO+ZbdHOr/ugc22/Ct6eDQZovPB7t+K9mUF KcJXOnExaMBDbi9iB+YcmBZkr8A4x77NP+tUHLP58sP0m2GaQhHlb1FVcrLq6zS+MTv/ 7wfkjahl/buVrNLFE2K96QjMLbDK1jwcUTxgo/aQgX++dY+ig043IBJq4+VcYrHlF72s /4jB2iNfymYe3M75WJCSoIIi7ziv+SYQAzE90vBWkq79x+gQAT7CnYyUwx5vQkM/gMU9 8DDQ== X-Gm-Message-State: AOUpUlHgcYYQ76VrawfOtgI1qOYtKaNHbA4rHTdfHCNiKzIksRMWVZPH OyQB+bPMgyhvcu6QVO0ct1LTKLn0N5vQgYi8wyVmcZ7N X-Google-Smtp-Source: AAOMgpetiylPYppwEMO7JX01lh+rdLiQbO182J88mCh8qGsPIEl/fayftR/ifZhqW0yv4MGbAOzu//Dk3zt9kQCi+zk= X-Received: by 2002:a2e:2d0a:: with SMTP id t10-v6mr3152571ljt.8.1532191309609; Sat, 21 Jul 2018 09:41:49 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 2002:ab3:7851:0:0:0:0:0 with HTTP; Sat, 21 Jul 2018 09:41:48 -0700 (PDT) In-Reply-To: <201806261807.w5QI7Hod072088@repo.freebsd.org> References: <201806261807.w5QI7Hod072088@repo.freebsd.org> From: Alan Somers Date: Sat, 21 Jul 2018 10:41:48 -0600 X-Google-Sender-Auth: sXgYzhbE0egvw9-2QJySHI2q8ZE Message-ID: Subject: Re: svn commit: r335673 - in head: etc/defaults etc/rc.d lib/geom/eli share/man/man5 To: Ben Woods Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 16:41:52 -0000 On Tue, Jun 26, 2018 at 12:07 PM, Ben Woods wrote: > Author: woodsb02 (ports committer) > Date: Tue Jun 26 18:07:16 2018 > New Revision: 335673 > URL: https://svnweb.freebsd.org/changeset/base/335673 > > Log: > geli attach multiple providers > > Allow attaching of multiple geli providers at once if they use same > passphrase and keyfiles. > > This is helpful when the providers being attached are not used for boot, > and therefore the existing code to first try the cached password when > tasting the providers during boot does not apply. > > Multiple providers with the same passphrase and keyfiles can be attached > at the same time during system start-up by adding the following to > rc.conf: > geli_groups="storage backup" > geli_storage_flags="-k /etc/geli/storage.keys" > geli_storage_devices="ada0 ada1" > geli_backup_flags="-j /etc/geli/backup.passfile -k > /etc/geli/backup.keys" > geli_backup_devices="ada2 ada3" > > Reviewed by: wblock, delphij, jilles > Approved by: sobomax (src), bcr (doc) > Differential Revision: https://reviews.freebsd.org/D12644 > > Modified: > head/etc/defaults/rc.conf > head/etc/rc.d/geli > head/lib/geom/eli/geli.8 > head/lib/geom/eli/geom_eli.c > head/share/man/man5/rc.conf.5 > It looks like this change is causing several of geli's tests to fail in CI. Could you please take a look? The failure mode is that "geli attach" exits 0 when it should fail instead. https://ci.freebsd.org/job/FreeBSD-head-amd64-test/lastCompletedBuild/testReport/