From nobody Wed Oct 1 09:38:44 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cc8xx0x1Nz69GXT; Wed, 01 Oct 2025 09:38:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cc8xx0DrMz3Gdg; Wed, 01 Oct 2025 09:38:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zOdN4pyZEhcmaLnxzhb2FDZ3grSrQJH+n7IJq8rgg6M=; b=XBybX0rVKJNSPzJpe3EnQruyYvWHWSoh7YCaYDKTQVrApGQwsN5i2tdxFzQ3GlO/S+OHX8 rAR+iyEv0XMld1QxEKHvodMgk1KW0ioRlYMaGGW2ZYqttZkfWfJM/0ot/S6i330jpnnUZ7 YbMH7wDO3R+hb1AXvZUrK9rj2RAxhmp9YIV7RO+FvSvY7T2dMo/vd/SGHGWS50V/sf0sOU SZuJGVA9Vp3L1BQ85Ew0jvgmymXnRStPJurXzVY+uE0/g3R7bJW5iJLYZqI4cZOl93yqAr GsGg8hdCoBiSjynhX1NMtKd0G4fQTIsXYdd9jg6mOatoiT+1tj5a2Wgj97xO8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zOdN4pyZEhcmaLnxzhb2FDZ3grSrQJH+n7IJq8rgg6M=; b=JtfOzxzAZ8QiBWUGRkgWfocGDOudavlTneyk23hRXwuYceG8KdZXZ9xjxHlPv+0v9vl449 Ok9ugX13D1xcW/F/R53xgBb8epuakvPi6L6i4x+6rAcpFkGXmZL0AfJ2fI40q7VylUtvbB xJIu4fJ9idun7AijC9desYge16CqNqK/VTQP40CEe1UVD4EWjxQfOXRUFY3baR7PN8Hggs 8FPqdsQk8zmMpwCRO3ROFxQ6hOkEfJqGHmOM5KobhZPaGxPpGwcT1bBGUBIEE9IftHWEaV 5mzi/AP4mFwW+VC3HWymBW0GHHccNNqC4TnMjJjjGmHVZZ0ONzcWIezpQ/2n1A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759311525; a=rsa-sha256; cv=none; b=GQ38qQhjgycEFDCWhwdijYq7+8yv7sCoK3qzIQj94cxAqKSd1zAkyf+ZJEG9vAve+ukzzv fdm84GRt12BcRpMn+BQpI4CgDi/uVvR3vEcN+R44vrQSZUZxnEKV6edd5f2UEbmyGjO8y9 5ClwGpc92/cIztMMd9k2eJKgbzfTl8p8dkGRKMxVOcDMt7gf3SKfPr/BKtllKXaQogGx9v /JROBqQpnBAWJu36trdFwyuupV4gjsLMNFXg5fDshkXeEYvV+wV5B+//YVcHDYmyvtXeO6 gL2m63w0SU8/cEK69rKJcSCI/ZLS6N/xCGAsd4xevEgeX0QC/lAGA5yKahRq2Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cc8xw6cP9z2Lg; Wed, 01 Oct 2025 09:38:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5919ciHo016292; Wed, 1 Oct 2025 09:38:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5919ciQJ016290; Wed, 1 Oct 2025 09:38:44 GMT (envelope-from git) Date: Wed, 1 Oct 2025 09:38:44 GMT Message-Id: <202510010938.5919ciQJ016290@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: 2dc10f2a49af - stable/13 - ng_tty: don't increment m_data List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 2dc10f2a49afc688c103758a41d5fb8cab5fd1c2 Auto-Submitted: auto-generated The branch stable/13 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=2dc10f2a49afc688c103758a41d5fb8cab5fd1c2 commit 2dc10f2a49afc688c103758a41d5fb8cab5fd1c2 Author: Ahmad Khalifa AuthorDate: 2025-09-24 15:01:57 +0000 Commit: Ahmad Khalifa CommitDate: 2025-10-01 08:50:46 +0000 ng_tty: don't increment m_data Stop incrementing m_data so the callee can read the mbuf. MFC after: 3 days Reviewed by: glebius Differential Revision: https://reviews.freebsd.org/D52702 (cherry picked from commit 57d5a8feda3fd25a650eaab5998db13633d62d2d) --- sys/netgraph/ng_tty.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c index 6f8667c664bb..c7d8a1b64eac 100644 --- a/sys/netgraph/ng_tty.c +++ b/sys/netgraph/ng_tty.c @@ -485,9 +485,7 @@ ngt_rint(struct tty *tp, char c, int flags) } /* Add char to mbuf */ - *mtod(m, u_char *) = c; - m->m_data++; - m->m_len++; + *(u_char *)mtodo(m, m->m_len++) = c; m->m_pkthdr.len++; /* Ship off mbuf if it's time */