From owner-cvs-all Thu Sep 19 6:32:48 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB66237B401; Thu, 19 Sep 2002 06:32:47 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D80F43E77; Thu, 19 Sep 2002 06:32:47 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Received: from freefall.freebsd.org (truckman@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g8JDWlCo073275; Thu, 19 Sep 2002 06:32:47 -0700 (PDT) (envelope-from truckman@freefall.freebsd.org) Received: (from truckman@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g8JDWkoF073261; Thu, 19 Sep 2002 06:32:46 -0700 (PDT) Message-Id: <200209191332.g8JDWkoF073261@freefall.freebsd.org> From: Don Lewis Date: Thu, 19 Sep 2002 06:32:46 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/fs/unionfs union_vnops.c src/sys/gnu/ext2fs ext2_vnops.c src/sys/kern vfs_syscalls.c vnode_if.src src/sys/ufs/ufs ufs_vnops.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG truckman 2002/09/19 06:32:46 PDT Modified files: sys/fs/unionfs union_vnops.c sys/gnu/ext2fs ext2_vnops.c sys/kern vfs_syscalls.c vnode_if.src sys/ufs/ufs ufs_vnops.c Log: VOP_FSYNC() requires that it's vnode argument be locked, which nfs_link() wasn't doing. Rather than just lock and unlock the vnode around the call to VOP_FSYNC(), implement rwatson's suggestion to lock the file vnode in kern_link() before calling VOP_LINK(), since the other filesystems also locked the file vnode right away in their link methods. Remove the locking and and unlocking from the leaf filesystem link methods. Reviewed by: rwatson, bde (except for the unionfs_link() changes) Revision Changes Path 1.91 +15 -8 src/sys/fs/unionfs/union_vnops.c 1.72 +4 -11 src/sys/gnu/ext2fs/ext2_vnops.c 1.287 +3 -1 src/sys/kern/vfs_syscalls.c 1.57 +1 -1 src/sys/kern/vnode_if.src 1.208 +4 -11 src/sys/ufs/ufs/ufs_vnops.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message