From owner-svn-src-all@FreeBSD.ORG  Sun Jun 13 20:53:50 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 951631065673;
	Sun, 13 Jun 2010 20:53:50 +0000 (UTC)
	(envelope-from stefan@fafoe.narf.at)
Received: from fep28.mx.upcmail.net (fep28.mx.upcmail.net [62.179.121.48])
	by mx1.freebsd.org (Postfix) with ESMTP id 26CFD8FC0C;
	Sun, 13 Jun 2010 20:53:48 +0000 (UTC)
Received: from edge03.upcmail.net ([192.168.13.238]) by viefep19-int.chello.at
	(InterMail vM.8.01.02.02 201-2260-120-106-20100312) with ESMTP
	id <20100613203527.UEQU17503.viefep19-int.chello.at@edge03.upcmail.net>;
	Sun, 13 Jun 2010 22:35:27 +0200
Received: from mole.fafoe.narf.at ([213.47.85.26])
	by edge03.upcmail.net with edge
	id VYbS1e00s0a5KZh03YbTVf; Sun, 13 Jun 2010 22:35:27 +0200
X-SourceIP: 213.47.85.26
Received: by mole.fafoe.narf.at (Postfix, from userid 1001)
	id EEE8E6D41D; Sun, 13 Jun 2010 22:35:25 +0200 (CEST)
Date: Sun, 13 Jun 2010 22:35:25 +0200
From: Stefan Farfeleder <stefanf@FreeBSD.org>
To: mdf@FreeBSD.org
Message-ID: <20100613203524.GA1736@mole.fafoe.narf.at>
References: <201006130239.o5D2du3m086332@svn.freebsd.org>
	<20100613101025.GD1320@garage.freebsd.pl>
	<AANLkTik2X_x6cNsLWQTNqDHuN69IZgyMnM--0vhp36xk@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTik2X_x6cNsLWQTNqDHuN69IZgyMnM--0vhp36xk@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Cloudmark-Analysis: v=1.1 cv=K3uBg944YaUT+Qsu6bWO0a0V3uPy4DQNslbdoMCD4tw=
	c=1 sm=0 a=zSU5qxubI3IA:10 a=ADBQPqJMlbwA:10 a=kj9zAlcOel0A:10
	a=6I5d2MoRAAAA:8 a=Z6Coxr9PXiB70X_GTecA:9
	a=JxUT8T1Ef6QpYZcEb5Bqr55P6XkA:4 a=CjuIK1q_8ugA:10
	a=SV7veod9ZcQA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117
Cc: svn-src-head@freebsd.org, Lawrence Stewart <lstewart@freebsd.org>,
	svn-src-all@freebsd.org, src-committers@freebsd.org,
	Pawel Jakub Dawidek <pjd@freebsd.org>
Subject: Re: svn commit: r209119 - head/sys/sys
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jun 2010 20:53:50 -0000

On Sun, Jun 13, 2010 at 01:59:11PM +0000, mdf@FreeBSD.org wrote:
> 
> (Relevant but almost a thread hijack):
> 
> At Isilon we've run into a lot of problems with variable declarations
> in macros, especially with -Wshadow turned on.  We ended up
> backporting __COUNTER__ from later versions of gcc and then using it
> to make unique variable names.
> 
>  - is the backport (or a fresh implementation) something that could be
> done within the scope of the GPL license?
>  - is it something FreeBSD would be interested in?
>  - is __COUNTER__ supported by clang?
>  - if not, could it be?
> 
> -Wshadow found several nasty bugs in our code, and apart from a few
> spurious warnings it has been handy to have when building our
> filesystem.

In my opinion using non-standard C features just to work around warnings
is a bit questionable.  A more useful feature would be an attribute that
avoids -Wshadow warnings.

Regards,
Stefan