From owner-svn-src-all@freebsd.org Thu Dec 8 23:03:33 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1563EC6E1CB; Thu, 8 Dec 2016 23:03:33 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk0-x243.google.com (mail-qk0-x243.google.com [IPv6:2607:f8b0:400d:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C66E8A7C; Thu, 8 Dec 2016 23:03:32 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk0-x243.google.com with SMTP id x190so132489qkb.0; Thu, 08 Dec 2016 15:03:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EhmMZ3qpbSig0WPAUM4gfQu3hW1l0aq1fmupRPgVMJk=; b=uEeIo3DyUrYvhmc+cyhaEJcVu+fIMaAiV/PstB3zv6bPjYYtWuSvl/vQ01Yy/qFVQm r9atDDbpS38rsZ3zZDSw0EQY7B+wxWGsglE5/dAPNqtiCNUbNveU4t8dT0vfnK7aYY4J puvu+s0FPHl23QUJLdGGC5HY9GFSfAlZuUgQo1scl6/bH5qssqfCY8vSEWxyJZrfNPZq nhQ+7kHzuli32nU+3+nA3yvQIyq84Z9TRdCJrNEjxyQ2O+yZPkkzzPzgIiin6jm69MfS j0OZ/mpeU6kwRz3eAoWx+7pd/s0BpHylkFpppftvVmUEeWC0jxN53JwXjKNqWYTuAw+b 60FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=EhmMZ3qpbSig0WPAUM4gfQu3hW1l0aq1fmupRPgVMJk=; b=hpCqxwo7aAFZP1qaJfLKgiTp0KamulnRz1O2PwdArJHoJ45mFkUahNyFcdX54q2qeM 7X+nGXtTyfdbuPzkveM+VpVBXq2hJ8Bg2lEhC5oAjR8dLdRpqqJeZILyB0BY/eFHWgxc ny1tCcdfx2Kv86NytBv1XbA+hxhK1ht4N3enLJ2AKz9Yv6dzfaO/WqjQoMRhkfLT1ejI pDFhr6h45rVO2WZ3Zv3ZnDRy9/IRLyRV3gK2FSoLIwQdnEOepTXYDdGUYbKL2jYX4Ysu CNoDrLfge8qwWzlycqHhLxvkVxA+ceZgADt2lU+9tv1xAYayXtLCxvp9/YwYaNZs4Utv a07w== X-Gm-Message-State: AKaTC03a0wdOdFYZoa0/o4s/+Nz6CRJzglLLBaiW53GuTapX0222vPqBDH9LcvU+ygMPgg== X-Received: by 10.55.92.199 with SMTP id q190mr65666453qkb.303.1481238211858; Thu, 08 Dec 2016 15:03:31 -0800 (PST) Received: from wkstn-mjohnston.west.isilon.com (c-76-104-201-218.hsd1.wa.comcast.net. [76.104.201.218]) by smtp.gmail.com with ESMTPSA id f66sm18509992qkj.23.2016.12.08.15.03.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Dec 2016 15:03:31 -0800 (PST) Sender: Mark Johnston Date: Thu, 8 Dec 2016 15:09:43 -0800 From: Mark Johnston To: John Baldwin Cc: Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309658 - head/sys/vm Message-ID: <20161208230943.GA25503@wkstn-mjohnston.west.isilon.com> References: <201612062252.uB6Mqjhr019191@repo.freebsd.org> <20161207212647.GO27748@FreeBSD.org> <20161207221548.GA33409@wkstn-mjohnston> <1613947.95yg9mLP0R@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1613947.95yg9mLP0R@ralph.baldwin.cx> User-Agent: Mutt/1.7.1 (2016-10-04) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2016 23:03:33 -0000 On Thu, Dec 08, 2016 at 07:50:17AM -0800, John Baldwin wrote: > On Wednesday, December 07, 2016 02:15:49 PM Mark Johnston wrote: > > On Wed, Dec 07, 2016 at 01:26:47PM -0800, Gleb Smirnoff wrote: > > > On Tue, Dec 06, 2016 at 10:52:45PM +0000, Mark Johnston wrote: > > > M> Author: markj > > > M> Date: Tue Dec 6 22:52:45 2016 > > > M> New Revision: 309658 > > > M> URL: https://svnweb.freebsd.org/changeset/base/309658 > > > M> > > > M> Log: > > > M> Provide dummy sysctls for v_cache_count and v_tcached. > > > M> > > > M> Some utilities (notably top(1)) exit if any of their input sysctls don't > > > M> exist, and the removal of the above-mentioned PG_CACHE-related sysctls > > > M> makes it difficult to run such utilities on different versions of the > > > M> kernel without recompiling. > > > M> > > > M> Requested by: bde > > > M> > > > M> Modified: > > > M> head/sys/vm/vm_meter.c > > > M> > > > M> Modified: head/sys/vm/vm_meter.c > > > M> ============================================================================== > > > M> --- head/sys/vm/vm_meter.c Tue Dec 6 22:48:28 2016 (r309657) > > > M> +++ head/sys/vm/vm_meter.c Tue Dec 6 22:52:45 2016 (r309658) > > > M> @@ -314,3 +314,14 @@ VM_STATS_VM(v_forkpages, "VM pages affec > > > M> VM_STATS_VM(v_vforkpages, "VM pages affected by vfork()"); > > > M> VM_STATS_VM(v_rforkpages, "VM pages affected by rfork()"); > > > M> VM_STATS_VM(v_kthreadpages, "VM pages affected by fork() by kernel"); > > > M> + > > > M> +#ifndef BURN_BRIDGES > > > M> +/* > > > M> + * Provide compatibility sysctls for the benefit of old utilities which exit > > > M> + * with an error if they cannot be found. > > > M> + */ > > > M> +SYSCTL_UINT(_vm_stats_vm, OID_AUTO, v_cache_count, CTLFLAG_RD, > > > M> + (u_int *)NULL, 0, "Dummy for compatibility"); > > > M> +SYSCTL_UINT(_vm_stats_vm, OID_AUTO, v_tcached, CTLFLAG_RD, > > > M> + (u_int *)NULL, 0, "Dummy for compatibility"); > > > M> +#endif > > > > > > IMHO, there should be some garbage collecting timeout for them. I'd suggest to > > > delete them from head after stable/12 branch is forked. > > > > The intent was to improve compatibility with old userlands, not just to > > help bridge the transition from 11.0 to 12.0. In general I'm all for > > removing cruft, but these sysctls are unobtrusive and I don't see any > > reason to remove them in a specific time frame provided that nothing > > else breaks compatibility for top(1) (and vmstat(8)). Please feel free > > to add a timeout if you still disagree, though. > > I would suggest sticking them under COMPAT_FREEBSD11 then. That would give > users control via the COMPAT_FREEBSD options the way we do with other > compat shims. The only nit is you need to add the COMPAT_FREEBSD11 option > first (probably in a separate commit). Ok. I've put up a CR here if anyone would like to take a look first: https://reviews.freebsd.org/D8736