From owner-svn-src-all@freebsd.org Wed Aug 15 16:07:31 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E60111066169; Wed, 15 Aug 2018 16:07:30 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6E51093FF1; Wed, 15 Aug 2018 16:07:30 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w7FG7SLS048318; Wed, 15 Aug 2018 09:07:28 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w7FG7Smo048317; Wed, 15 Aug 2018 09:07:28 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201808151607.w7FG7Smo048317@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r337826 - stable/11/bin/ls In-Reply-To: To: Ed Maste Date: Wed, 15 Aug 2018 09:07:27 -0700 (PDT) CC: "Rodney W. Grimes" , Kyle Evans , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 16:07:31 -0000 [ Charset UTF-8 unsupported, converting... ] > On 14 August 2018 at 21:41, Rodney W. Grimes > wrote: > >> Author: kevans > >> Date: Wed Aug 15 01:29:02 2018 > >> New Revision: 337826 > >> URL: https://svnweb.freebsd.org/changeset/base/337826 > >> > >> Log: > >> MFC r337506: ls(1): Enable colors with COLORTERM is set in the environment > >> > >> COLORTERM is the de facto standard, while CLICOLOR is generally specific to > >> FreeBSD and ls(1). > > > > I have already seen one "Who enabled %&*@(#$@) colored ls output in 12?" > > Seems that the defaults for xfce terminal is to have COLORTERM. > > If xfce's default is to request colour via the de-facto environment > variable then we should generally honour it -- the answer to the > %&*@(#$@) question is "you did, via your terminal's default." And I pointed that out to them, but it is kinda a POLA, people have had to take explicit action to get colorls, that is no longer true and that suprises them when they see it. -- Rod Grimes rgrimes@freebsd.org