From owner-svn-ports-all@FreeBSD.ORG Wed Jan 15 10:25:22 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B1948269; Wed, 15 Jan 2014 10:25:22 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 72AE011F7; Wed, 15 Jan 2014 10:25:22 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id D9E0CBDC71; Wed, 15 Jan 2014 11:25:16 +0100 (CET) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) by prod2.absolight.net (Postfix) with ESMTPA id B0968BDC70; Wed, 15 Jan 2014 11:25:16 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by atuin.in.mat.cc (Postfix) with ESMTP id 4AC44CC633B3; Wed, 15 Jan 2014 11:25:15 +0100 (CET) Date: Wed, 15 Jan 2014 11:25:13 +0100 From: Mathieu Arnold To: Dima Panov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r339755 - in head/net: freerdp freerdp/files remmina remmina-plugin-gnome remmina-plugin-i18n remmina-plugin-nx remmina-plugin-rdp remmina-plugin-telepathy remmina-plugin-vnc remmina-pl... Message-ID: <7E3F90C451355FBA1A00A827@atuin.in.mat.cc> In-Reply-To: <201401150544.s0F5ihZ8069160@svn.freebsd.org> References: <201401150544.s0F5ihZ8069160@svn.freebsd.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jan 2014 10:25:22 -0000 +--On 15 janvier 2014 05:44:43 +0000 Dima Panov wrote: | -PORTVERSION= 1.0.2 | +PORTVERSION= 1.1.0.b20130711 | +DISTVERSION= 1.1.0-beta+2013071101 You can't set both PORTVERSION and DISTVERSION. As you're using github as a source, the DISTVERSION doesn't matter as it's set by the ports framework, it'll be computed from the rest, you should remove it. You should convert all those options foo to the new framework, first by adding OPTIONS_SUB=yes to get all the PLIST_SUB generated automatically, and for the rest, a bit like : | .if ${PORT_OPTIONS:MDIRECTFB} | -LIB_DEPENDS+= directfb:${PORTSDIR}/devel/directfb | +LIB_DEPENDS+= libdirectfb.so:${PORTSDIR}/devel/directfb | CMAKE_ARGS+= -DWITH_DIRECTFB=ON | PLIST_SUB+= DIRECTFB="" | # currently DirectFB option fails with clang | @@ -53,7 +53,7 @@ PLIST_SUB+= DIRECTFB="@comment " | .endif DIRECTFB_LIB_DEPENDS= libdirectfb.so:${PORTSDIR}/devel/directfb DIRECTFB_CMAKE_ON= -DWITH_DIRECTFB=ON DIRECTFB_USE= gcc=yes | +.if ${PORT_OPTIONS:MGSTREAMER} | +CMAKE_ARGS+= -DWITH_GSTREAMER=ON | +USE_GSTREAMER= yes | +.else | +CMAKE_ARGS+= -DWITH_GSTREAMER=OFF | +.endif GSTREAMER_CMAKE_ON= -DWITH_GSTREAMER=ON GSTREAMER_CMAKE_OFF= -DWITH_GSTREAMER=OFF GSTREAMER_USE= gstreamer=yes And so on. -- Mathieu Arnold