Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 3 Dec 2015 17:01:00 +0000 (UTC)
From:      Raphael Kubo da Costa <rakuco@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r402888 - head/devel/thrift-cpp
Message-ID:  <201512031701.tB3H10jV069263@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rakuco
Date: Thu Dec  3 17:01:00 2015
New Revision: 402888
URL: https://svnweb.freebsd.org/changeset/ports/402888

Log:
  Use BROKEN_FreeBSD_9 instead of IGNORE and version checks after r402877.
  
  Not only does this simplify the Makefile, but BROKEN is the correct choice
  here ("BROKEN is reserved for ports that currently do not compile, install,
  deinstall, or run correctly. Use it for ports where the problem is believed
  to be temporary", says the Porter's Handbook).
  
  Suggested by marino@.

Modified:
  head/devel/thrift-cpp/Makefile

Modified: head/devel/thrift-cpp/Makefile
==============================================================================
--- head/devel/thrift-cpp/Makefile	Thu Dec  3 16:57:47 2015	(r402887)
+++ head/devel/thrift-cpp/Makefile	Thu Dec  3 17:01:00 2015	(r402888)
@@ -44,13 +44,11 @@ CONFIGURE_ARGS+=	\
 		--without-ruby \
 		--without-go
 
-.include <bsd.port.pre.mk>
-
 # src/thrift/transport/TSSLSocket.cpp:147: error: 'TLSv1_1_method' was not declared in this scope
 # src/thrift/transport/TSSLSocket.cpp:149: error: 'TLSv1_2_method' was not declared in this scope
-.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000015
-IGNORE=		does not build with 9.x base OpenSSL
-.endif
+BROKEN_FreeBSD_9=	does not build with 9.x base OpenSSL
+
+.include <bsd.port.pre.mk>
 
 .if ${COMPILER_TYPE} == clang
 USE_CXXSTD=	c++11



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201512031701.tB3H10jV069263>