From owner-freebsd-ports@FreeBSD.ORG Tue Nov 22 17:30:02 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C44FA1065670 for ; Tue, 22 Nov 2011 17:30:02 +0000 (UTC) (envelope-from jhelfman@experts-exchange.com) Received: from mail.experts-exchange.com (mail.experts-exchange.com [72.29.183.251]) by mx1.freebsd.org (Postfix) with ESMTP id 93FC38FC0A for ; Tue, 22 Nov 2011 17:30:02 +0000 (UTC) Received: from mail.experts-exchange.com (localhost [127.0.0.1]) by mail.experts-exchange.com (Postfix) with ESMTP id 376716F3074; Tue, 22 Nov 2011 09:30:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=e-e.com; h= user-agent:organization:in-reply-to:content-disposition :content-type:content-type:mime-version:references:message-id :subject:subject:from:from:date:date:received:received:received; s=ee; t=1321983002; x=1323797402; bh=PseIrU7lITX2SXS5i+DhWYpBdE Sh2c4fIw+2PFPZnJc=; b=P2OwK1ie6gzJj8iJHMktCE/68eSJ/0BnF3LsQ82Bed rblYiQCzJjBxEjpZN2o74IfsQUvhhLs97e3bYyTA8/ik0Y1uaOPkCAAAWSQSbPsj GkVfK41rBN/uAjPS877FG/YTFmSRcOa5Hy06aYB9E5zblMTLtzOA6xU+RH4PJm/W 0= X-Virus-Scanned: amavisd-new at experts-exchange.com Received: from mail.experts-exchange.com ([127.0.0.1]) by mail.experts-exchange.com (mail.experts-exchange.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D8Se9Af0s1ps; Tue, 22 Nov 2011 09:30:02 -0800 (PST) Received: from experts-exchange.com (unknown [192.168.103.120]) by mail.experts-exchange.com (Postfix) with SMTP id 09EEE6F306F; Tue, 22 Nov 2011 09:30:02 -0800 (PST) Received: (nullmailer pid 1327 invoked by uid 1001); Tue, 22 Nov 2011 17:29:41 -0000 Date: Tue, 22 Nov 2011 09:29:41 -0800 From: Jason Helfman To: Wesley Shields Message-ID: <20111122172941.GA67967@dormouse.experts-exchange.com> References: <4EC8CC53.5000806@infracaninophile.co.uk> <20111122132922.GC56180@atarininja.org> <4ECBC36F.6040607@infracaninophile.co.uk> <20111122154924.GD56180@atarininja.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20111122154924.GD56180@atarininja.org> X-Operating-System: FreeBSD 8.2-RELEASE amd64 Organization: Experts-Exchange, LLC. http://www.experts-exchange.com X-Living-The-Dream: I love the SLO Life! User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-ports Subject: Re: More nitpicks from the department of redundancy department... X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2011 17:30:03 -0000 On Tue, Nov 22, 2011 at 10:49:24AM -0500, Wesley Shields thus spake: >On Tue, Nov 22, 2011 at 03:44:47PM +0000, Matthew Seaman wrote: >> On 22/11/2011 13:29, Wesley Shields wrote: >> > On Mon, Nov 21, 2011 at 12:42:59AM -0500, Eitan Adler wrote: >> >> On Sun, Nov 20, 2011 at 10:18 AM, Eitan Adler wrote: >> >>> On Sun, Nov 20, 2011 at 4:45 AM, Matthew Seaman >> >>> wrote: >> >>>> >> >>>> PORT_DBDIR?= /var/db/ports is the default setting in bsd.ports.mk -- the >> >>>> following ports redefine it to exactly the same value: >> >>>> [ snip ] >> >>> >> >>> Thanks for the report - I'll handle these. >> >> >> >> Sorry for the empty promise. Something came up and I won't have the >> >> time to look at these :( - maybe someone else can take them up >> > >> > Hi Matthew! >> > >> > If you could please file these in a PR and CC me I will try and work >> > through all of these. >> >> Done: http://www.freebsd.org/cgi/query-pr.cgi?pr=162754 > >Thank you! I will try and clean all this up, but as I'm sure you're >aware we are coming up on a holiday in the states so my time is limited >for the next few days. I will look at this as time permits though! > >-- WXS I did have a brief look at some of these and it was a great catch. One item I did find interesting is a number of these define LATEST_LINK, but it just matches ${PORTNAME}, so the LATEST_LINK can more than likely be dropped -- on a case-by-case basis, of course. -jgh -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5