From owner-svn-src-head@freebsd.org  Mon Sep 28 16:01:46 2020
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6F85B42604E;
 Mon, 28 Sep 2020 16:01:46 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4C0S220jHGz4X01;
 Mon, 28 Sep 2020 16:01:45 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 08SG1cZE049443
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Mon, 28 Sep 2020 19:01:41 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 08SG1cZE049443
Received: (from kostik@localhost)
 by tom.home (8.16.1/8.16.1/Submit) id 08SG1cYD049442;
 Mon, 28 Sep 2020 19:01:38 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Mon, 28 Sep 2020 19:01:38 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Kyle Evans <kevans@freebsd.org>
Cc: Alan Somers <asomers@freebsd.org>,
 src-committers <src-committers@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>,
 svn-src-head <svn-src-head@freebsd.org>
Subject: Re: svn commit: r366207 - head/lib/libc/gen
Message-ID: <20200928160138.GP2643@kib.kiev.ua>
References: <202009272226.08RMQf1h054050@repo.freebsd.org>
 <20200927231519.GI2643@kib.kiev.ua>
 <CAOtMX2iUKpFrJC1vUJ5_AF75L_GDr_4Rui2TdrA-qPLRc8aDNw@mail.gmail.com>
 <20200928150405.GO2643@kib.kiev.ua>
 <CACNAnaHWmZuusQeYMFiDG1wBxtJK6c8qa0Nv8im2M9SExP2gRA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACNAnaHWmZuusQeYMFiDG1wBxtJK6c8qa0Nv8im2M9SExP2gRA@mail.gmail.com>
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM,
 NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home
X-Rspamd-Queue-Id: 4C0S220jHGz4X01
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
 ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US];
 REPLY(-4.00)[]
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Sep 2020 16:01:46 -0000

On Mon, Sep 28, 2020 at 10:06:55AM -0500, Kyle Evans wrote:
> I would be tempted to just revert the rest of the local modifications
> (sans negative check, maybe) and widen it in the one spot that the
> compiler complains about:
> 
> -                     if (strlcpy(buf, execpath, buflen_) >= buflen_)
> +                     if (strlcpy(buf, execpath, buflen) >= (size_t)buflen)
> 
> I had expressed this in the review, but with no particular conviction.
If this is the only place where the warning occurs, IMO it would be quite
good to reduce the change.