Date: Tue, 4 Feb 2020 05:42:31 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Steve Wills <swills@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r525015 - in head/graphics: . xviewer Message-ID: <20200204054231.GB3138@FreeBSD.org> In-Reply-To: <2d41afa7-54b0-677d-5dc3-f7106b366cb5@FreeBSD.org> References: <202002030639.0136d7FL098267@repo.freebsd.org> <2d41afa7-54b0-677d-5dc3-f7106b366cb5@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 03, 2020 at 02:38:23PM -0500, Steve Wills wrote: > On 2/3/20 1:39 AM, Alexey Dokuchaev wrote: > > New Revision: 525015 > > URL: https://svnweb.freebsd.org/changeset/ports/525015 > > > > [...] > > +post-patch: > > + @${REINPLACE_CMD} -e '/CINNAMON_DESKTOP_REQUIRED/s,3\.2\.0,2.4.2,' \ > > + ${WRKSRC}/configure.ac > > + > > This would be better as a patch. Not really. Then `x11/cinnamon-desktop' port would get updated, this "patch" could be removed with much less repochurn than the real patch file. Until they become too heavy, I find sed(1) expressions easier and more robust. I usually provide enough context so they'd either DTRT or nothing. > [...] > -GLIB_SCHEMAS= org.x.viewer.enums.xml org.x.viewer.gschema.xml > +GLIB_SCHEMAS= org.x.viewer.enums.xml \ > + org.x.viewer.gschema.xml These two words are short enough to not overflow the 80-char line when placed together, I don't see the need to force the wrap. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200204054231.GB3138>