From owner-svn-src-all@freebsd.org Thu May 21 13:42:01 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 600082D87AD; Thu, 21 May 2020 13:42:01 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49SW4m5bzYz3Wdg; Thu, 21 May 2020 13:42:00 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id 04LDfrIp076844 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 21 May 2020 16:41:56 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 04LDfrIp076844 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id 04LDfr8Z076843; Thu, 21 May 2020 16:41:53 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 21 May 2020 16:41:52 +0300 From: Konstantin Belousov To: Antoine Brodin Cc: jhb@freebsd.org, markj@freebsd.org, src-committers , svn-src-all , svn-src-head@freebsd.org Subject: Re: svn commit: r361303 - in head: lib/libc/gen libexec/rtld-elf sys/sys Message-ID: <20200521134152.GE64045@kib.kiev.ua> References: <202005202208.04KM8QPA020707@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 49SW4m5bzYz3Wdg X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2020 13:42:01 -0000 On Thu, May 21, 2020 at 03:02:07PM +0200, Antoine Brodin wrote: > On Thu, May 21, 2020 at 12:08 AM Konstantin Belousov wrote: > > > > Author: kib > > Date: Wed May 20 22:08:26 2020 > > New Revision: 361303 > > URL: https://svnweb.freebsd.org/changeset/base/361303 > > > > Log: > > Change the samantic of struct link_map l_addr member. > > > > It previously returned the object map base address, while all other > > ELF operating systems return load offset, i.e. the difference between > > map base and the link base. > > > > Explain the meaning of the field in the man page. > > > > Stop filling the mips-only l_offs member, which is apparently unused. > > > > PR: 246561 > > Requested by: Damjan Jovanovic > > Reviewed by: emaste, jhb, cem (previous version) > > Sponsored by: The FreeBSD Foundation > > MFC after: 1 week > > Differential revision: https://reviews.freebsd.org/D24918 > > > > Modified: > > head/lib/libc/gen/dlinfo.3 > > head/libexec/rtld-elf/rtld.c > > head/sys/sys/link_elf.h > > Hi, > > After this commit, some ports fail to build with signal 11. > For instance lang/perl5.30 fails to build with default options (DTRACE on) > Disabling the DTRACE option makes it able to build again. > I see, thank you for reporting. So drti.c:dtrace_dof_init() does read l_addr, and the dtrace code assumes that l_addr is the base, not relocbase. Mark, was dofhp_addr initialization changed comparing to Solaris ?