From owner-dev-commits-src-all@freebsd.org Sun Mar 14 00:15:23 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CF26F568676; Sun, 14 Mar 2021 00:15:23 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dyg6z5RzFz3sk9; Sun, 14 Mar 2021 00:15:23 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 9522B88A1; Sun, 14 Mar 2021 00:15:23 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:470:7a58:0:57d:7ad7:3c94:1ec3] (unknown [IPv6:2001:470:7a58:0:57d:7ad7:3c94:1ec3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 10B643E7CC; Sun, 14 Mar 2021 01:15:21 +0100 (CET) From: Dimitry Andric Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_A3542C0C-E7BF-4613-9BA6-36B2CE593D92"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: git: 9097e3cbcac4 - main - Partially revert libcxxrt changes to avoid _Unwind_Exception change Date: Sun, 14 Mar 2021 01:15:11 +0100 In-Reply-To: <20210313183812.77b74819@FreeBSD.org> Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" To: =?utf-8?Q?T=C4=B3l_Coosemans?= References: <202103131354.12DDsnKR065154@gitrepo.freebsd.org> <20210313183812.77b74819@FreeBSD.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Mar 2021 00:15:23 -0000 --Apple-Mail=_A3542C0C-E7BF-4613-9BA6-36B2CE593D92 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On 13 Mar 2021, at 18:38, T=C4=B3l Coosemans wrote: >=20 > On Sat, 13 Mar 2021 13:54:49 GMT Dimitry Andric = wrote: >> The branch main has been updated by dim: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D9097e3cbcac455eb0dedd097d8d5548c= 72568d0a >>=20 >> commit 9097e3cbcac455eb0dedd097d8d5548c72568d0a >> Author: Dimitry Andric >> AuthorDate: 2021-03-13 13:54:24 +0000 >> Commit: Dimitry Andric >> CommitDate: 2021-03-13 13:54:24 +0000 >>=20 >> Partially revert libcxxrt changes to avoid _Unwind_Exception = change ... >> --- a/contrib/libcxxrt/unwind-itanium.h >> +++ b/contrib/libcxxrt/unwind-itanium.h >> @@ -79,12 +79,9 @@ struct _Unwind_Exception >> { >> uint64_t exception_class; >> _Unwind_Exception_Cleanup_Fn exception_cleanup; >> - uintptr_t private_1; >> - uintptr_t private_2; >> -#if __SIZEOF_POINTER__ =3D=3D 4 >> - uint32_t reserved[3]; >> -#endif >> - } __attribute__((__aligned__)); >> + unsigned long private_1; >> + unsigned long private_2; >> + } ; >=20 > Shouldn't these definitions be the same as the ones in GCC? If you want to keep the ABI compatible with what it was, no. Otherwise, = you could consider it. But for what gain? -Dimitry --Apple-Mail=_A3542C0C-E7BF-4613-9BA6-36B2CE593D92 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCYE1VjwAKCRCwXqMKLiCW oxCsAKDfhglHmT2HK4yRHyDVK+2BULydnACfZDbJyxWu/MG/O2RUPa0VNoRBhKo= =jJXN -----END PGP SIGNATURE----- --Apple-Mail=_A3542C0C-E7BF-4613-9BA6-36B2CE593D92--