From owner-cvs-all@FreeBSD.ORG Sat Apr 3 22:09:39 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 391091065675 for ; Sat, 3 Apr 2010 22:09:39 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id D5D848FC1C for ; Sat, 3 Apr 2010 22:09:37 +0000 (UTC) Received: (qmail 24851 invoked by uid 399); 3 Apr 2010 22:09:36 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 3 Apr 2010 22:09:36 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4BB7BC9E.2060706@FreeBSD.org> Date: Sat, 03 Apr 2010 15:09:34 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.9) Gecko/20100330 Thunderbird/3.0.4 MIME-Version: 1.0 To: Ion-Mihai Tetcu References: <201004031443.o33Eh5N6062631@repoman.freebsd.org> In-Reply-To: <201004031443.o33Eh5N6062631@repoman.freebsd.org> X-Enigmail-Version: 1.0.1 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, Sahil Tandon , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/postpals pkg-plist ports/mail/postpals/files postpals-taillog.in postpals.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2010 22:09:39 -0000 On 04/03/10 07:43, Ion-Mihai Tetcu wrote: > itetcu 2010-04-03 14:43:05 UTC > > FreeBSD ports repository > > Modified files: > mail/postpals pkg-plist > mail/postpals/files postpals-taillog.in postpals.in > Log: > - fix plist (deinstall) > - fix rc script > > Submitted by: Sahil Tandon (maintainer) > > Revision Changes Path > 1.2 +2 -2 ports/mail/postpals/files/postpals-taillog.in > 1.2 +2 -2 ports/mail/postpals/files/postpals.in > 1.3 +1 -0 ports/mail/postpals/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/postpals/files/postpals-taillog.in.diff?&r1=1.1&r2=1.2&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/postpals/files/postpals.in.diff?&r1=1.1&r2=1.2&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/postpals/pkg-plist.diff?&r1=1.2&r2=1.3&f=h The command_interpreter change is a good one, but it should probably be changed to %%PERL%% since that should work whether or not the link is installed in /usr/bin. Couple other problems, the scripts used %%RC_SUBR%% which is going away, hopefully soon if portmgr actually commits my patch. :) I've already fixed that one. The other problem is with this: case "$postpals_enable" in [Yy][Ee][Ss] | 1 | [Oo][Nn] | [Tt][Rr][Uu][Ee]) ;; *) echo "To make use of $name you must first set $rcvar=\"YES\" in /etc/rc.conf" ;; esac Two problems there, first if you're going to test a boolean in rc.d it should always be done with checkyesno to be on the safe side. But more importantly, the user not defining _enable, and/or defining it and setting it to !yes is a configuration that we support, so my preference would be for this whole test to go away. :) Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/