From owner-svn-ports-all@FreeBSD.ORG  Wed Apr 24 19:40:05 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from hammer.pct.niksun.com (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by hub.freebsd.org (Postfix) with ESMTP id 72D9C254;
 Wed, 24 Apr 2013 19:40:05 +0000 (UTC)
 (envelope-from jkim@FreeBSD.org)
Message-ID: <51783462.4090904@FreeBSD.org>
Date: Wed, 24 Apr 2013 15:37:06 -0400
From: Jung-uk Kim <jkim@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130408 Thunderbird/17.0.5
MIME-Version: 1.0
To: Chris Rees <crees@freebsd.org>
Subject: Re: svn commit: r316469 - head/databases/slony1v2
References: <201304241850.r3OIovPc079999@svn.freebsd.org>
 <51782B87.2090000@FreeBSD.org>
 <alpine.BSF.2.00.1304242105250.29749@olgeni.olgeni>
 <517830D2.5060600@FreeBSD.org>
 <CADLo83_VLFq4kZ683u9e63T-mfF5am1-MGbFR3K4kV6L5TviQQ@mail.gmail.com>
In-Reply-To: <CADLo83_VLFq4kZ683u9e63T-mfF5am1-MGbFR3K4kV6L5TviQQ@mail.gmail.com>
X-Enigmail-Version: 1.5.1
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 svn-ports-all@freebsd.org, Jimmy Olgeni <olgeni@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Apr 2013 19:40:06 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-04-24 15:30:57 -0400, Chris Rees wrote:
> On 24 April 2013 20:21, Jung-uk Kim <jkim@freebsd.org> wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>> 
>> On 2013-04-24 15:08:00 -0400, Jimmy Olgeni wrote:
>>> 
>>> On Wed, 24 Apr 2013, Jung-uk Kim wrote:
>>> 
>>>> On 2013-04-24 14:50:57 -0400, Jimmy Olgeni wrote:
>>>>> Author: olgeni Date: Wed Apr 24 18:50:57 2013 New
>>>>> Revision: 316469 URL:
>>>>> http://svnweb.freebsd.org/changeset/ports/316469
>>>>> 
>>>>> Log: - Use bsd.port.options.mk. - PORTDOCS should not be 
>>>>> conditional. - Whitespace fix.
>>>> ...
>>>> 
>>>> bsd.port.mk says "(PORTDOCS) should not be set when no 
>>>> documentation files are installed" and I believe it is
>>>> actually correct.
>>> 
>>> I found this on the Porter's Handbook:
>>> 
>>> If a directory is listed in PORTDOCS or matched by a glob
>>> pattern from this variable, the entire subtree of contained
>>> files and directories will be registered in the final packing
>>> list. If the DOCS option has been unset then files and
>>> directories listed in PORTDOCS would not be installed or added
>>> to port packing list.
>>> 
>>> It seems to behave correctly, at least in the PORTDOCS=* case.
>> 
>> It may work for now because bsd.options.mk has backward compat
>> shim, i.e.,
>> 
>> ## Now some compatibility .if empty(PORT_OPTIONS:MDOCS) 
>> NOPORTDOCS=     yes .endif
>> 
>> It won't work when we deprecate the compat shims.
> 
> Yes, bsd.port.mk needs fixing there.

Agreed.

We should refrain from blindly making PORTDOCS unconditional until we
resolve the issue, IMHO.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iQEcBAEBAgAGBQJReDRiAAoJECXpabHZMqHOs1QH/0abe9AgMBkuLyY9IBg198Q8
0Whp8Of/Ko57JhZVLV1xA5PmSrlKjg1uNiRD5PXPSbxXdn2tX1c2heuA5v+vHDSj
5ef2YuLJ89yaUc9YdRC3FJo4mUS+4HPaLFO20RqQoFC1+K+OAEk6OKRyrLTVMFCh
p5K7q5BCI47UiZ38CJrE4m9uM0yGWe9S2KGX47IO2xB8voEKsqEnGk9r3NEprzrj
FhZs3MSadROkY98HXDD5iThPP8nL2SXEa6LTEsBQZflcpOnajjgjQo4ZTJW0/ch7
/24qmCT6Yj71zGeZyxi4Ics7OrLqA+f7BWz0FdrrfZktyq7Vf65XwU/QQ8vIf2c=
=lbEf
-----END PGP SIGNATURE-----