From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Mar 7 20:57:00 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1EAE0950 for ; Sat, 7 Mar 2015 20:57:00 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DE7B6338 for ; Sat, 7 Mar 2015 20:56:59 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t27Kuxrs099907 for ; Sat, 7 Mar 2015 20:56:59 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 198379] net/liboping: Update to 1.8.0, Fix MASTER_SITES, WWW, Request MAINTAINER'ship Date: Sat, 07 Mar 2015 20:57:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch, patch-ready X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: portmaster@bsdforge.com X-Bugzilla-Status: Open X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Mar 2015 20:57:00 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198379 --- Comment #9 from Chris Hutchinson --- (In reply to Kubilay Kocak from comment #8) > Thanks for the update Chris! No. Thank *you* for taking the time to review this, Kubilay Kocak. :-) > > 1) Add USES=pathfix to fix: > > pkg-plist: +lib/pkgconfig/liboping.pc > > The correct location for .pc files is: > > +libdata/pkgconfig/liboping.pc > > portlint(8) should have picked that up. > > See: Mk/Uses/pathfix.mk Dunno why, but portlint said nothing. But I have it listed now. > > 2) I still believe the original COMMENT is much better as it matches > upstream. Minor issue I know, but I personally have a *very* strong > preference to have ports reflect upstream information as closely as possible > for user confidence. I concede (with *minor* amendment). :-) > > 3) As per original review: STRIP_CMD should take place in post-install. > There is still a pre-install: STRIP_CMD Tried that originally, but there were issues (see additional QA log for details). > > 4) While you're there, and if you haven't already: > > Add DEVELOPER=yes in /etc/make.conf to enable extra QA/Sanity checks: > > See: Mk/bsd.sanity.mk The box I develop on, is only used for development. make.conf(5) has one line: DEVELOPER=yes But, yes. Good advice. :-) Please see the added QA log, that contains a running dialog. I think [hope] this satisfies everything. Thanks, Kubilay Kocak! --Chris -- You are receiving this mail because: You are the assignee for the bug.