Date: Mon, 24 Sep 2012 07:28:01 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Kevin Lo <kevlo@freebsd.org> Cc: Garrett Cooper <yanegomi@gmail.com>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: Re: svn commit: r240850 - head/lib/libstand Message-ID: <20120924042801.GQ37286@deviant.kiev.zoral.com.ua> In-Reply-To: <505FC00B.5020204@FreeBSD.org> References: <201209230838.q8N8c6Tu056083@svn.freebsd.org> <20120923105220.GL37286@deviant.kiev.zoral.com.ua> <CAGH67wQf5whjgQmXD3Ln_-r=WsLMYrBQUBj_G-HoGf1a5F_4cg@mail.gmail.com> <505FC00B.5020204@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--A+JrWpA8iZwaHvaR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 24, 2012 at 10:06:03AM +0800, Kevin Lo wrote: > On 2012/09/24 03:27, Garrett Cooper wrote: > > On Sun, Sep 23, 2012 at 3:52 AM, Konstantin Belousov > > <kostikbel@gmail.com> wrote: > >> On Sun, Sep 23, 2012 at 08:38:06AM +0000, Kevin Lo wrote: > >>> Author: kevlo > >>> Date: Sun Sep 23 08:38:06 2012 > >>> New Revision: 240850 > >>> URL: http://svn.freebsd.org/changeset/base/240850 > >>> > >>> Log: > >>> Avoid NULL dereference > >>> > >>> Modified: > >>> head/lib/libstand/nfs.c > > ... > > > >> I do not see how this change is useful. libstand' Free() function hand= les > >> NULL parameter fine, as well as all other free(3) implementations I am > >> aware of. > > +1. free(3) should silently ignore NULL parameters passed into it. >=20 > Well, The patch is harmless. I suppose I could argue it is a safety belt > against free(NULL) should be silently ignored. It is code bloat. > I have no problem changing it back, but there are two other places where > the same comment could apply. Yes, this is good to apply as well. >=20 > Index: lib/libstand/nfs.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- lib/libstand/nfs.c (revision 240879) > +++ lib/libstand/nfs.c (working copy) > @@ -606,10 +606,8 @@ nfs_open(const char *upath, struct open_file *f) > error =3D 0; >=20 > out: > - if (newfd) > - free(newfd); > - if (path) > - free(path); > + free(newfd); > + free(path); > #else > currfd->iodesc =3D desc; >=20 > @@ -1256,10 +1254,8 @@ nfs_open(const char *upath, struct open_file *f) > error =3D 0; >=20 > out: > - if (newfd) > - free(newfd); > - if (path) > - free(path); > + free(newfd); > + free(path); > #else > currfd->iodesc =3D desc; >=20 >=20 > > Thanks, > > Garrett > > >=20 > Kevin --A+JrWpA8iZwaHvaR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlBf4VAACgkQC3+MBN1Mb4ggZACfVhiiwDwkZ7D4ixXVVHMoSvc6 FTkAoK1g/WOn/HlG6kA7f5abtXmjcf9g =6NZP -----END PGP SIGNATURE----- --A+JrWpA8iZwaHvaR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120924042801.GQ37286>