Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 04 Feb 2012 10:48:19 +0100
From:      Niclas Zeising <zeising@daemonic.se>
To:        Robert Millan <rmh@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r230972 - in head: share/mk sys/amd64/conf sys/i386/conf sys/modules sys/modules/drm sys/modules/sound/driver sys/modules/usb tools/build/options
Message-ID:  <4F2CFEE3.6070306@daemonic.se>
In-Reply-To: <201202040054.q140siBP012241@svn.freebsd.org>
References:  <201202040054.q140siBP012241@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-02-04 01:54, Robert Millan wrote:
> Author: rmh
> Date: Sat Feb  4 00:54:43 2012
> New Revision: 230972
> URL: http://svn.freebsd.org/changeset/base/230972
> 
> Log:
>   Add MK_SOURCELESS build option. Setting MK_SOURCELESS to "no" will disable
>   kernel modules that include binary-only code.
>   
>   More fine-grained control is provided via MK_SOURCELESS_HOST (for native code
>   that runs on host CPU) and MK_SOURCELESS_UCODE (for microcode).
>   
>   Reviewed by:	julian, delphij, freebsd-arch
>   Approved by:	kib (mentor)
>   MFC after:	2 weeks
> 
> Added:
>   head/sys/amd64/conf/WITHOUT_SOURCELESS   (contents, props changed)
>   head/sys/amd64/conf/WITHOUT_SOURCELESS_HOST   (contents, props changed)
>   head/sys/amd64/conf/WITHOUT_SOURCELESS_UCODE   (contents, props changed)
>   head/sys/i386/conf/WITHOUT_SOURCELESS   (contents, props changed)
>   head/sys/i386/conf/WITHOUT_SOURCELESS_HOST   (contents, props changed)
>   head/sys/i386/conf/WITHOUT_SOURCELESS_UCODE   (contents, props changed)
>   head/tools/build/options/WITHOUT_SOURCELESS   (contents, props changed)
>   head/tools/build/options/WITHOUT_SOURCELESS_HOST   (contents, props changed)
>   head/tools/build/options/WITHOUT_SOURCELESS_UCODE   (contents, props changed)
> Modified:
>   head/share/mk/bsd.own.mk
>   head/sys/modules/Makefile
>   head/sys/modules/drm/Makefile
>   head/sys/modules/sound/driver/Makefile
>   head/sys/modules/usb/Makefile
> 
> 
> Added: head/sys/amd64/conf/WITHOUT_SOURCELESS_HOST
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sys/amd64/conf/WITHOUT_SOURCELESS_HOST	Sat Feb  4 00:54:43 2012	(r230972)
> @@ -0,0 +1,10 @@
> +#
> +# WITHOUT_SOURCELESS_UCODE -- Disable drivers that include sourceless
                        ^^^^^
This seems like a typo. Shouldn't it read HOST instead?
> +# native code for host CPU.
> +#
> +# $FreeBSD$
> +
> +nodevice	hpt27xx
> +nodevice	hptmv
> +nodevice	hptrr
> +nodevice	nve
> 
> 
> Added: head/sys/i386/conf/WITHOUT_SOURCELESS_HOST
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sys/i386/conf/WITHOUT_SOURCELESS_HOST	Sat Feb  4 00:54:43 2012	(r230972)
> @@ -0,0 +1,10 @@
> +#
> +# WITHOUT_SOURCELESS_UCODE -- Disable drivers that include sourceless
                        ^^^^^
Same here.
> +# native code for host CPU.
> +#
> +# $FreeBSD$
> +
> +nodevice	hpt27xx
> +nodevice	hptmv
> +nodevice	hptrr
> +nodevice	nve
> 
> 

Also, can you please regenerate the src.conf manual page? Perhaps it
should be documented somewhere which drivers/modules that are affected
by this as well.
Thank you!
Regards!
-- 
Niclas



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F2CFEE3.6070306>