From owner-svn-src-all@freebsd.org Fri Jul 10 02:27:54 2015 Return-Path: <owner-svn-src-all@freebsd.org> Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9D0053F4C; Fri, 10 Jul 2015 02:27:54 +0000 (UTC) (envelope-from gnn@freebsd.org) Received: from smtp.hungerhost.com (smtp.hungerhost.com [216.38.53.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7478310EC; Fri, 10 Jul 2015 02:27:54 +0000 (UTC) (envelope-from gnn@freebsd.org) Received: from pool-108-54-164-204.nycmny.fios.verizon.net ([108.54.164.204]:49747 helo=[192.168.1.16]) by vps.hungerhost.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85) (envelope-from <gnn@freebsd.org>) id 1ZDO2Z-0005XU-Bv; Thu, 09 Jul 2015 22:27:51 -0400 From: "George Neville-Neil" <gnn@freebsd.org> To: "Peter Wemm" <peter@wemm.org> Cc: svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285336 - in head/sys: netipsec opencrypto Date: Thu, 09 Jul 2015 22:27:40 -0400 Message-ID: <E82240DD-05F4-4CAD-B478-FF0948816FF0@freebsd.org> In-Reply-To: <15342729.MI2b1tqqeb@overcee.wemm.org> References: <201507091816.t69IGawf097288@repo.freebsd.org> <15342729.MI2b1tqqeb@overcee.wemm.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_MailMate_E4AAF0D0-6D10-4223-AEFE-371759A562B3_="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Mailer: MailMate (1.9.1r5084) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - freebsd.org X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id: gnn@neville-neil.com X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/> List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 10 Jul 2015 02:27:54 -0000 This is an OpenPGP/MIME signed message (RFC 3156 and 4880). --=_MailMate_E4AAF0D0-6D10-4223-AEFE-371759A562B3_= Content-Type: text/plain On 9 Jul 2015, at 18:26, Peter Wemm wrote: > On Thursday, July 09, 2015 06:16:36 PM George V. Neville-Neil wrote: >> Author: gnn >> Date: Thu Jul 9 18:16:35 2015 >> New Revision: 285336 >> URL: https://svnweb.freebsd.org/changeset/base/285336 >> >> Log: >> Add support for AES modes to IPSec. These modes work both in software >> only mode and with hardware support on systems that have AESNI >> instructions. >> >> Differential Revision: D2936 >> Reviewed by: jmg, eri, cognet >> Sponsored by: Rubicon Communications (Netgate) >> >> Modified: >> head/sys/netipsec/xform_ah.c >> head/sys/netipsec/xform_esp.c > >> @@ -953,6 +989,11 @@ esp_output_cb(struct cryptop *crp) >> case CRYPTO_SHA2_512_HMAC: >> alen = esph->hashsize/2; >> break; >> + case CRYPTO_AES_128_GMAC: >> + case CRYPTO_AES_192_GMAC: >> + case CRYPTO_AES_256_GMAC: >> + alen = esph->hashsize; >> + break; >> default: >> alen = AH_HMAC_HASHLEN; >> break; > > This introduces a LINT compile failure: > > /usr/src/sys/netipsec/xform_esp.c:992:9: error: use of undeclared identifier > 'CRYPTO_AES_128_GMAC' > case CRYPTO_AES_128_GMAC: > ^ > /usr/src/sys/netipsec/xform_esp.c:993:9: error: use of undeclared identifier > 'CRYPTO_AES_192_GMAC' > case CRYPTO_AES_192_GMAC: > ^ > /usr/src/sys/netipsec/xform_esp.c:994:9: error: use of undeclared identifier > 'CRYPTO_AES_256_GMAC' > case CRYPTO_AES_256_GMAC: > ^ > 3 errors generated. > --- xform_esp.o --- > Apologies, fixed in 285347. BTW The LINT conf in amd64 is ignored. Why? Best, George --=_MailMate_E4AAF0D0-6D10-4223-AEFE-371759A562B3_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlWfLZwACgkQYdh2wUQKM9LGAwCgw/bjdr417DbaTVE/K18WZDPl irMAnR9aEO714KNo8NMJ3nKd4CKIgB+w =fE+B -----END PGP SIGNATURE----- --=_MailMate_E4AAF0D0-6D10-4223-AEFE-371759A562B3_=--