From owner-freebsd-bugs@freebsd.org Mon Nov 26 19:07:17 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3AB0E1141377 for ; Mon, 26 Nov 2018 19:07:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id C6C4E843C1 for ; Mon, 26 Nov 2018 19:07:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 8614F1141375; Mon, 26 Nov 2018 19:07:16 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 607D21141374 for ; Mon, 26 Nov 2018 19:07:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EEC93843B7 for ; Mon, 26 Nov 2018 19:07:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 1A9021FF7C for ; Mon, 26 Nov 2018 19:07:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wAQJ7EqJ019633 for ; Mon, 26 Nov 2018 19:07:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wAQJ7Eie019632 for bugs@FreeBSD.org; Mon, 26 Nov 2018 19:07:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 232206] [truss] update strsize parameter handling Date: Mon, 26 Nov 2018 19:07:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: devnexen@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: C6C4E843C1 X-Spamd-Result: default: False [1.80 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_LONG(0.79)[0.792,0]; NEURAL_SPAM_MEDIUM(0.52)[0.525,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; NEURAL_SPAM_SHORT(0.49)[0.486,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 19:07:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232206 --- Comment #4 from David Carlier --- The bug is mainly all about fixing a possible overflow when using string si= ze parameter, basically by giving a value over an integer maximum value. Easily reproducible by "trussing" the syslog process with this sort of valu= e (I just print out the value on purpose): truss -s 27836487264287642746284662746874678412834 ... makes the process aborting /usr/obj/usr/src/amd64.amd64/usr.bin/truss/truss -s 23894723984789237473278482974382479238794728379843828794 -p 1509 STRSIZE -1 select(10,{ 3 5 8 9 },0x0,0x0,0x0) =3D 1 (0x1) Bus error (core dumped) whereas with a more "reasonable" value it works as always /usr/obj/usr/src/amd64.amd64/usr.bin/truss/truss -s 80 -p 1553 STRSIZE 80 select(10,{ 3 5 8 9 },0x0,0x0,0x0) =3D 1 (0x1) read(5,"Firmware Error (ACPI): Could not resolve [\\_SB.PCI0.LPCB.HEC.ECRD], AE_NOT_FOUN"...,2047) =3D 394 (0x18a) writev(14,[{"Nov 26 19:06:24",15},{" ",1},{"freeflame",9},{" ",1},{"kernel",6},{": ",2},{"Firmware Error (ACPI): Could not resolve [\\_SB.PCI0.LPCB.HEC.ECRD], AE_NOT_FOUN"...,102},{"\n",1}],8) =3D 137 (0x89) writev(14,[{"Nov 26 19:06:24",15},{" ",1},{"freeflame",9},{" ",1},{"kernel",6},{": ",2},{"ACPI Error: Method parse/execution failed \\_TZ.TZ00._TMP, AE_NOT_FOUND (2018103"...,93},{"\n",1}],8) =3D 128 (0x80) writev(14,[{"Nov 26 19:06:24",15},{" ",1},{"freeflame",9},{" ",1},{"kernel",6},{": ",2},{"Firmware Error (ACPI): Could not resolve [\\_SB.PCI0.LPCB.HEC.ECRD], AE_NOT_FOUN"...,102},{"\n",1}],8) =3D 137 (0x89) writev(14,[{"Nov 26 19:06:24",15},{" ",1},{"freeflame",9},{" ",1},{"kernel",6},{": ",2},{"ACPI Error: Method parse/execution failed \\_TZ.TZ01._TMP, AE_NOT_FOUND (2018103"...,93},{"\n",1}],8) =3D 128 (0x80) read(5,0x7fffffffde50,2047) ERR#35 'Resource temporari= ly unavailable' select(10,{ 3 5 8 9 },0x0,0x0,{ 0.000000 }) =3D 0 (0x0) fsync(0xe) =3D 0 (0x0) select(10,{ 3 5 8 9 },0x0,0x0,0x0) =3D 1 (0x1) ... --=20 You are receiving this mail because: You are the assignee for the bug.=