Date: Sat, 3 Aug 2002 08:47:35 +0300 (EEST) From: Valentin Nechayev <netch@netch.kiev.ua> To: FreeBSD-gnats-submit@FreeBSD.org Cc: snar@paranoia.ru Subject: ports/41277: libparanoia: gets(): exit_violation() is forgotten in one branch Message-ID: <200208030547.g735lZ56003747@iv.nn.kiev.ua>
next in thread | raw e-mail | index | archive | help
>Number: 41277
>Category: ports
>Synopsis: libparanoia: gets(): exit_violation() is forgotten in one branch
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Aug 02 23:00:04 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Valentin Nechayev <netch@netch.kiev.ua>
>Release: FreeBSD 4.5-STABLE-20020224 i386
>Organization:
private
>Environment:
ports/security/libparanoia,
Makefile version is 1.8, PORTVERSION is 1.4
>Description:
In gets(), two return's exist, and both should be wrapped with exit_violation.
In current version, one is forgotten.
>How-To-Repeat:
>Fix:
Add following as files/patch-ab (and bump PORTREVISION, of course):
=== cut ===
--- gets.c.orig Wed Dec 30 17:05:40 1998
+++ gets.c Fri Mar 22 23:29:05 2002
@@ -68,8 +68,10 @@
}
for (s = buf; (c = getchar()) != '\n';)
if (c == EOF)
- if (s == buf)
+ if (s == buf) {
+ exit_violation();
return (NULL);
+ }
else
break;
else
=== end cut ===
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200208030547.g735lZ56003747>