From owner-cvs-src-old@FreeBSD.ORG Tue Mar 17 14:42:10 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F129F1065742 for ; Tue, 17 Mar 2009 14:42:10 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DC8868FC17 for ; Tue, 17 Mar 2009 14:42:10 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n2HEgA9i049230 for ; Tue, 17 Mar 2009 14:42:10 GMT (envelope-from bms@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n2HEg99c049229 for cvs-src-old@freebsd.org; Tue, 17 Mar 2009 14:42:09 GMT (envelope-from bms@repoman.freebsd.org) Message-Id: <200903171442.n2HEg99c049229@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to bms@repoman.freebsd.org using -f From: Bruce M Simpson Date: Tue, 17 Mar 2009 14:41:54 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet igmp.c in.c in_mcast.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2009 14:42:12 -0000 bms 2009-03-17 14:41:54 UTC FreeBSD src repository Modified files: sys/netinet igmp.c in.c in_mcast.c Log: SVN rev 189931 on 2009-03-17 14:41:54Z by bms Deal with the case where ifma_protospec may be NULL, during any IPv4 multicast operations which reference it. There is a potential race because ifma_protospec is set to NULL when we discover the underlying ifnet has gone away. This write is not covered by the IF_ADDR_LOCK, and it's difficult to widen its scope without making it a recursive lock. It isn't clear why this manifests more quickly with 802.11 interfaces, but does not seem to manifest at all with wired interfaces. With this change, the 802.11 related panics reported by sam@ and cokane@ should go away. It is not the right fix, that requires more thought before 8.0. Idea from: sam Tested by: cokane Revision Changes Path 1.64 +20 -5 src/sys/netinet/igmp.c 1.124 +8 -1 src/sys/netinet/in.c 1.18 +9 -0 src/sys/netinet/in_mcast.c