From owner-freebsd-hackers Sun Oct 19 11:51:02 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id LAA25215 for hackers-outgoing; Sun, 19 Oct 1997 11:51:02 -0700 (PDT) (envelope-from owner-freebsd-hackers) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by hub.freebsd.org (8.8.7/8.8.7) with SMTP id LAA25206 for ; Sun, 19 Oct 1997 11:50:55 -0700 (PDT) (envelope-from j@uriah.heep.sax.de) Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id UAA26468; Sun, 19 Oct 1997 20:50:53 +0200 Received: (from j@localhost) by uriah.heep.sax.de (8.8.7/8.8.5) id UAA01482; Sun, 19 Oct 1997 20:40:19 +0200 (MET DST) Message-ID: <19971019204018.PF25731@uriah.heep.sax.de> Date: Sun, 19 Oct 1997 20:40:18 +0200 From: j@uriah.heep.sax.de (J Wunsch) To: freebsd-hackers@FreeBSD.ORG Cc: proff@iq.org (Julian Assange) Subject: Re: nasty problem with vnode and other disk drivers? References: <19971019170838.1109.qmail@iq.org> X-Mailer: Mutt 0.60_p2-3,5,8-9 Mime-Version: 1.0 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <19971019170838.1109.qmail@iq.org>; from Julian Assange on Oct 19, 1997 17:08:38 -0000 Sender: owner-freebsd-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Julian Assange wrote: > physio() is passed a uio argument, with an offset into the device. > It then builds a struct buf, and calculates b_blkno like so: > > bp->b_blkno = btodb(uio->uio_offset); > > (btodb just divides by 512) (and so on) All this nasty shiftomania is subject to be killed some day, for b_blkno should be replaced by a b_offset field (of type off_t). I think a number of (not so unimportant to the project effort :) people already agreed that this is the way to go, so it's only a matter of time, until someone can spend the energy required to make this change, and debug everything. Hopefully, this should still be before 3.0 hits the surface. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)