From owner-svn-ports-all@FreeBSD.ORG  Wed Jan 15 11:17:10 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id B138DE2C; Wed, 15 Jan 2014 11:17:10 +0000 (UTC)
Date: Wed, 15 Jan 2014 11:17:10 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Rusmir Dusko <nemysis@FreeBSD.org>
Subject: Re: svn commit: r338572 - head/games/palomino
Message-ID: <20140115111710.GA50575@FreeBSD.org>
References: <20140113104200.GA80610@nemysis4now>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140113104200.GA80610@nemysis4now>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jan 2014 11:17:10 -0000

On Mon, Jan 13, 2014 at 11:42:00AM +0100, Rusmir Dusko wrote:
> In my earlier email correspondence with makcs regarding DESKTOP_ENTRIES,
> he stated some interesting arguments, as to why would one, do so.
> 
> This is from his last email:
> 
> > I suppose you simply removed 'false', so that DESKTOP_ENTRIES had only 5
> > elements.  If you need empty field, you shall use double quotes (""), e.g:
> > 
> > DESKTOP_ENTRIES=	"Name" "" "Icon" "Exec" "Categories" ""
> > 
> > This desktop entry will use ports ${COMMENT} for second field, and empty
> > StartupNotify field.

I've played a bit with DESKTOP_ENTRIES, it seems that ${COMMENT} is indeed
gets added by default, so "" is okay.  As for StartupNotify, it also looks
like that forcing it to 'false' might be in fact wrong.  Per specification:

  "If true, it is KNOWN that the application will send a "remove" message
   when started with the DESKTOP_STARTUP_ID environment variable set.  If
   false, it is KNOWN that the application does not work with startup
   notification at all (does not shown any window, breaks even when using
   StartupWMClass, etc.).  If absent, a reasonable handling is up to
   implementations (assuming false, using StartupWMClass, etc.)"

That said, emptying ${COMMENT} and 'false' values looks correct.  Thanks
for the insight.

./danfe