From nobody Wed Oct 1 09:38:45 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cc8xy1ycLz69GV0; Wed, 01 Oct 2025 09:38:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cc8xy0zy9z3GlB; Wed, 01 Oct 2025 09:38:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p2f6c4TcOYRzLMIAYiqp93lIk0CIqfSmgK3mXuQGILs=; b=hcijZH0CZZE9xHMZlrBupndLuCUOD2tFWA+K4z1t0Zwy2NTVkeHjcRs5C1wNBKK+yUggyU ObG5qjrDrxLuLxvgY84AKMfP9z5Ec7CyMBPZHhW6gNHYULOaF4fQ7tskqHoP5OO6mVH4xz LTeozgv+iw6Z+our7Q+7ySuwKfwKNO71rnd+pBrhK+b+0mik/LsXsFrrvZ2yMzZcE5CAE3 9pX6fzIl5JpEwm9iYSyQW52sjf/65kzmi+TwklcIn/hSaS7LQuf0OmZpbBzT7D33g7Nrer JCt8fusdaXdgs033lJycOeB0Xiw/Na7dijg/Jy4d1walLdXjcSxr3GLdBkvJGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p2f6c4TcOYRzLMIAYiqp93lIk0CIqfSmgK3mXuQGILs=; b=r2sm9WTo2XLrZFcg9UtZGpyHkO5yqIrUIwqG5OpF7RzZVv48kaMA0NZU9D5B87jlpMC+e4 +x/7e1/WzVeigyU3RgJi4q0CBwnvMdzfNqgJ52kuvrbFkUHki6oQS9qtui9BOd09FHidbx ddom5uKIr0Xa+vJS4y5H4vC+ke1GL1QdHouk9qSCOv6RF3FlTOmFDNoOvwoTrRBxWcE0ph naW8rMjvwlpo1INR6WvUOblQ6VHmqxMgywjO7B/7l5E9WJn8WyXG9dfc0+/rHbc1qUzJVW iIsjCbJxo10hYWBQcAa8Uchc603qMelbDcH7pwi1duTfQ24CtavHfyO+v9548A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759311526; a=rsa-sha256; cv=none; b=pq3/et4mU7YpLPeuYMQg55Xg3EXTOJe6kcTusIY65i42ruYWdhCzMsKaCtJE69929UsWsB /Fcw+Ixd6kKoOxcyYt0GBeZ15ZId6zY31UNlBHrxrQnPneuUWC3cfRXl4drFUrg1c/IZfp 1YOISfs7q+MEl+rwqaLCklog0yYK/HBQpMyUB03uX8AYYnwBEflzWBYWTeZymuPI83ImxV qUY5ON4PlqC1/nKyl+wFXCKjsvx58c+42JgjAwXkyR3t8LesIqOq/HSGQ+OT1rb6G2n6j8 52XYQ9FmEqxBW74Bwm2ci5GL+qAU14KO0V2C7ZJKPnH7fyWxTpENWlDQ6w11NQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cc8xy0Q36z1vh; Wed, 01 Oct 2025 09:38:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5919cj96016333; Wed, 1 Oct 2025 09:38:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5919cjud016330; Wed, 1 Oct 2025 09:38:45 GMT (envelope-from git) Date: Wed, 1 Oct 2025 09:38:45 GMT Message-Id: <202510010938.5919cjud016330@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: 51cac1f186f5 - stable/13 - ng_tty: copy to the correct mbuf List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 51cac1f186f549522aad8a0858ea1ff4413cb8fb Auto-Submitted: auto-generated The branch stable/13 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=51cac1f186f549522aad8a0858ea1ff4413cb8fb commit 51cac1f186f549522aad8a0858ea1ff4413cb8fb Author: Ahmad Khalifa AuthorDate: 2025-09-25 16:54:28 +0000 Commit: Ahmad Khalifa CommitDate: 2025-10-01 08:50:57 +0000 ng_tty: copy to the correct mbuf memcpy should copy to the current mbuf, otherwise we're copying to the first mbuf in the chain over and over. Reported by: kevans Reviewed by: glebius MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D52713 (cherry picked from commit e05521121f05a1b1e0d7c7b5fbe79f83fc303cd0) --- sys/netgraph/ng_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c index c7d8a1b64eac..0e3230a66f66 100644 --- a/sys/netgraph/ng_tty.c +++ b/sys/netgraph/ng_tty.c @@ -427,7 +427,7 @@ ngt_rint_bypass(struct tty *tp, const void *buf, size_t len) for (mb = m; mb != NULL; mb = mb->m_next) { length = min(M_TRAILINGSPACE(mb), len - total); - memcpy(mtod(m, char *), (const char *)buf + total, length); + memcpy(mtod(mb, char *), (const char *)buf + total, length); mb->m_len = length; total += length; m->m_pkthdr.len += length;