From owner-svn-ports-head@freebsd.org  Thu Feb  8 07:13:53 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16D02F09150;
 Thu,  8 Feb 2018 07:13:53 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id C589A77677;
 Thu,  8 Feb 2018 07:13:52 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id A467C2E67; Thu,  8 Feb 2018 07:13:52 +0000 (UTC)
Date: Thu, 8 Feb 2018 07:13:52 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Ganael LAPLANCHE <martymac@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r460940 - in head/games: afternoonstalker
 burgerspace cosmosmash
Message-ID: <20180208071352.GA63012@FreeBSD.org>
References: <201802041634.w14GYHVW017651@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201802041634.w14GYHVW017651@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Feb 2018 07:13:53 -0000

On Sun, Feb 04, 2018 at 04:34:17PM +0000, Ganael LAPLANCHE wrote:
> New Revision: 460940
> URL: https://svnweb.freebsd.org/changeset/ports/460940
> 
> Log:
>   Fix build with Clang 6 (C++14 by default)

... by forcing gnu++98 without giving the details of the breakages and
why they were not properly fixed instead. :-)

I appreciate fixing the build, but USE_CXXSTD should be used only if
proper fix would be hard, or the patch would be way too long.  Clang 6
might be too pedantic, but it often reveals real bugs in the code, so
it's better not simply suppress them with USE_CXXSTD.  At least give
some details so interested committer could come by and attempt to find
a better fix.  Thanks,

./danfe