From owner-svn-src-all@freebsd.org Tue Oct 6 23:16:55 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5B2249D0286; Tue, 6 Oct 2015 23:16:55 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0129.outbound.protection.outlook.com [65.55.169.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 569F265D; Tue, 6 Oct 2015 23:16:53 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from CO2PR05CA038.namprd05.prod.outlook.com (10.141.241.166) by BY1PR0501MB1381.namprd05.prod.outlook.com (10.160.107.139) with Microsoft SMTP Server (TLS) id 15.1.286.20; Tue, 6 Oct 2015 23:16:51 +0000 Received: from BN1AFFO11FD022.protection.gbl (2a01:111:f400:7c10::113) by CO2PR05CA038.outlook.office365.com (2a01:111:e400:1429::38) with Microsoft SMTP Server (TLS) id 15.1.286.20 via Frontend Transport; Tue, 6 Oct 2015 23:16:51 +0000 Authentication-Results: spf=softfail (sender IP is 66.129.239.18) smtp.mailfrom=juniper.net; FreeBSD.org; dkim=none (message not signed) header.d=none;FreeBSD.org; dmarc=none action=none header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.18 as permitted sender) Received: from p-emfe01b-sac.jnpr.net (66.129.239.18) by BN1AFFO11FD022.mail.protection.outlook.com (10.58.52.82) with Microsoft SMTP Server (TLS) id 15.1.286.14 via Frontend Transport; Tue, 6 Oct 2015 23:16:50 +0000 Received: from magenta.juniper.net (172.17.27.123) by p-emfe01b-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 6 Oct 2015 16:16:46 -0700 Received: from chaos.jnpr.net (chaos.jnpr.net [172.21.16.28]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id t96NGYD30472; Tue, 6 Oct 2015 16:16:34 -0700 (PDT) (envelope-from sjg@juniper.net) Received: from chaos (localhost [IPv6:::1]) by chaos.jnpr.net (Postfix) with ESMTP id ECE28580A9; Tue, 6 Oct 2015 16:16:33 -0700 (PDT) To: Bryan Drewery CC: Warner Losh , , , , Subject: Re: svn commit: r288911 - head/share/mk In-Reply-To: <56143BB6.1010700@FreeBSD.org> References: <201510060418.t964Innu071170@repo.freebsd.org> <56140CAD.8080200@FreeBSD.org> <15356.1444161040@chaos> <5614286D.7020904@FreeBSD.org> <18968.1444166223@chaos> <56143BB6.1010700@FreeBSD.org> Comments: In-reply-to: Bryan Drewery message dated "Tue, 06 Oct 2015 14:23:02 -0700." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 24.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <25844.1444173393.1@chaos> Date: Tue, 6 Oct 2015 16:16:33 -0700 Message-ID: <23330.1444173393@chaos> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD022; 1:4GC4cq0rnTwizoMtWCo1okH4kiib6TSTBjd/pNnyggr/2yY84jcyEPyMiEEJ6C1F8rA7eXDWGm51ejiFEcjiTHYGphTeBTP60GpMuiYNY6Z7bJoehcByH9J7zC3aooOuq7Pz/YbWish1Iwxr1pkPl2hd3/ZFJawoQpUBOZnwzSByOVp8DMQs89EuinX5+fymXqwLx6OCmAURF9TwP02X2kBWTD+lgaXjOTSDJiDDwje8juKqqhS3+NPx3P1sFM6KU88KI+UZSeCiVlO2jFFT1QtU/VNf3rrRz/SoCTCtwK+i8e2N3XYkWYE2UoJMP9A8/gRp/L3+4JgNXzEFFZuJPA== X-Forefront-Antispam-Report: CIP:66.129.239.18; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(189002)(199003)(24454002)(86362001)(76506005)(110136002)(5008740100001)(23726002)(107886002)(5007970100001)(50986999)(97756001)(5001960100002)(46406003)(11100500001)(76176999)(6806005)(57986006)(46102003)(69596002)(64706001)(19580395003)(50466002)(450100001)(19580405001)(106466001)(50226001)(105596002)(97736004)(2950100001)(87936001)(47776003)(33716001)(93886004)(81156007)(189998001)(117636001)(77096005)(92566002)(42262002)(4001430100001)(62816006); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR0501MB1381; H:p-emfe01b-sac.jnpr.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0501MB1381; 2:BvchvLc25PbsJL2G0IZ1ACEtHDKKMa91RRUuV5pHKKVMQr/imeozApRj5hRKgRfLCbOgSx8NDUwYJmtcIx9rboG5TXrjUpfAxRLGDFX6HZX0TC1KThsbofhN0WhtmF/x7ZzgtMnXa/YQYkAhEU6VbJCrCcrBMMtNZhLNsVQcLMg=; 3:Ro0icfHpjgagW8cQgIU7/4TuNEQ9nWYQKL4xlsy4TzHIvVwgzqS7lVv40IkrImJMIXO0oJhgVFJCE5QfA/FYcjaYZhtfSgw1bdJ5nS3r4EoueUvlEbzm4wn37Q67JqXUVjfei0vk3v2WKHq8GqO4mo6evoRByuhjuGw7K7X41NeynuPNYfOeeHjCrCn8aFud0DniJYZcebRz+BGwy+vBjaV91JyPHRt2d0kFqVHSgII=; 25:QuquC1glMHLxT1yUTihePydlDZaMjOuO0Bw8FN23BX/GA0YDYpqADABurSf8BnJx3/RoELxwvOMwV369jZEjyLjPIQgSaCTQEhFsKxRBydjqXJ0ofjfDKKFrDApZ1SqgVXD6cAzAbrcFCU6ROdW1Nuwgiajo5pEOpNRaK3aunTLLVtKqPIVUr2762/RmiOLYcM+PXhRLiSpKoRdKiyVHFKEq5sAZpL8flavB/crYw7Jpo64p8oYQyCVlUdTkT9V3ks0G3BXsI3RxynRBqjczrA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0501MB1381; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0501MB1381; 20:rSREleIZKB2ZptO0h0EyosSSSWYaO/j78x7Y/CG4kd1CEuaiC+s3kreq/ddx1vOQO8OLl8lZL5OXcutMG9hAuW1RQ3yaYajwHK2Wa0A6/sm1/zJKqifj03vE8KcDaCj6rK625ducpyrVI4cQuqpgy7yncosBj+Mfi5lawBNJA9QvAUGLN5i12Mmzyp3tkoDQL1cvozXtZdPRvZa6KOWnl3qGbjNg7SiTLfb2x5q5nkYNi8fe5GGe1a705Td1tALYxKhs47olCPFGSLNcy/huZ15fa2uH6OkaY80tmGy5UCgI758k0a1vnc55OwyS5HimDIyYLg/s9sPCpsKWzpnp/8hZD8TinFRYTGNFpU3eUoOZl3Aav1ZWdv9Bks5FnYNx4Oha8cHI40k/bNCtxtjEUq181IbbtQ07mAQmWv3hRFELNxFcikyL1dCIAAh7/ryL2JT/G/zrdeAY1LnHp03A3+qZcfoCEy/gNpiHZdOgK2O8i1uBE7UMUo/u4jzBlEJ3; 4:km7FsJHIATrfUHjO4vCeNfZEh5RqaM9+Epzb37AYnRYk5ZYW+Yh8DYshIXCIejbLHhNIIokGWqXU0ZB4EBsM8coA4fhvNbZIlYklX6/A0GNQfQCItKYvQhwIlyKdOedw8ym1f9550T+oLtE8HziBRP5gqrnvKYUP6HpvDoMBeKcuqjaaLv6eobhNoAbC10fxF/hI6PGVUDp+2yggzdi0iU9fV7pK09oY3BTZdNBdAQlEI2QZGh+2azl7h6fHAWt5cehkJuMoireBxTyV9pH7MvlQjxWi4jdPSVEw4McBzGNmD2KnSvXQdQQUl8wdRfq2XiO5ejXprtdHIsCKDoK991XS6PE00UMfjNj1CXAhzlo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001); SRVR:BY1PR0501MB1381; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0501MB1381; X-Forefront-PRVS: 07215D0470 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0501MB1381; 23:Rv14q6k3vgVajl1c0qam/PImf91qnjNwL7AcvKc?= =?us-ascii?Q?PUofBCOBmzmS5kRZJqFKFGsJa0W0rwKCx47V955DTpWoVyKwQ+kP7rvPd8x6?= =?us-ascii?Q?U84nJTM+XRXS2ACgrUWqfQmcJmy+1BP3g/TTll2jyognUOoh+pE4VyH2IoM0?= =?us-ascii?Q?cmGYjohTWe/3CVmx2hvWdDUmZReP6SdIQBDFLx/r4+mlxd1oy9Vzos8dDnyL?= =?us-ascii?Q?t1Phv0BYxpy7JvQ4i0M91JvH2bUjG24JPAY+MZFfYPxda0ka6AkKPs1w36XA?= =?us-ascii?Q?EHTHIKHQB59V/XY/u7vQRhyNuILaqO/23LNitI+oSMoMoW8Cc1SnRlAhH6fA?= =?us-ascii?Q?kyfQq1Chh8c2Ah3eP4oxnlFhhJHHL6+zFrG2AFfvGgKyl1drwEPN1eBWDsMB?= =?us-ascii?Q?XazAaBnESD110OyWsXu34SIuycTFaJZZdfkF1bBvnnquuUKJ/+F3lo2C3vEJ?= =?us-ascii?Q?P3vttEz2IWdeOP4/lvsPOmq0LvRw+PDp/TOyP4B2oTjCJRlhuHDwDH63OrvH?= =?us-ascii?Q?EJj8naNUjtULPvcJ8WIQ15VEeLGr98ojfPWHD//u8kRm3fl5Na0zn5SIEPiE?= =?us-ascii?Q?h5xbMikDUgAyD5OiM7D9iItSrFGC28nhcAO8wp0D924AN/xQcgsIBmhCb0do?= =?us-ascii?Q?+XK6ilS4yy6WNIB1RuNY9g4iSYvehrbLrMp2tWuPJ3HgHqxQQV2z/v+3yoZ+?= =?us-ascii?Q?mssqq90VdMwj8/Pjv5kD648Rdiq0e0yk3+M/QQYZJ4+mclV0ZjNo3mcw0JEr?= =?us-ascii?Q?FSRv18mC8Jrd58lYm0JSLEQA1Jqlb9iw870SL5ZfKz+l2g4MDD/RglDAB21T?= =?us-ascii?Q?hMABl77RoLPivEr3cv0Wx/DXQq7EA9fLRfEqj6lvcsFRIBbC9LvArupv7b7l?= =?us-ascii?Q?ChA/p1OicwJphJMZYj8OvwDcF8o9U/n9PKJSGVBktrbnbN/PjA2JoHf6KUNB?= =?us-ascii?Q?F0XJs+ypDuTikpFmgsSTrMlI4zRpLJd6cBrFe+B45Nqyz7cymKUjx8RnS1Jx?= =?us-ascii?Q?64s7MNVeJakqvnMzEnBakthb9kf4LqGMsYD+xZ9SS3n0sYq07vCaq6h2jlSy?= =?us-ascii?Q?9LlfbVYJFPCZyJJMZfT7uLMXQYFdY0TB4+EqdsKQ8/yLYBN7llMrBGM3fKDN?= =?us-ascii?Q?/K8DzRbGoUMnJ6424V/5665DHh9mV6z6uQII8dDvyrfilAQWRD2ouZA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0501MB1381; 5:KXuZ49Hhp4R/Oxrwb7HptSXIYQj1hBYg1E7NGp6DRBO8QqFMwN+bsYZnE5CrKjZnhucUp+mh9yFugdNjwVt19wArinEsDDMiUAGteZKGDfBfCvGtuEPaBLpfDY/mUyvwHRxEWd9vGLoVGL5HqJs8AA==; 24:IW7YRJDJ1t1rOMRgSxGnzvFpyU8ZnHqQD+nffX80szsMNGRGr2jvpw0ZH0j84QcoXs4J582b9fexAbVe3zGVHLF6BnmTDde9ZILHnGCzWng=; 20:uxtEvPi9mjVa9jRWekvBSucDk8m/LEd8RMYwNrE1Z62pE6VFWmEGEXmFfApqo4pKcpI1+ImgF2mAP8oxuHYyEg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2015 23:16:50.3964 (UTC) X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.18]; Helo=[p-emfe01b-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0501MB1381 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 23:16:55 -0000 Bryan Drewery wrote: > > Are you refering to a src/share/mk which is sibling to src/ports/* or > > something else? > > > > Because with MAKESYSPATH=.../share/mk src/share/mk/sys.mk is what you > > should find. > > Right. That's what I'm referring to and what I prefer. Ok good. > If we update our checked in share/mk/custom.sys.env.mk file, we want all > builds to get it before having to install it to /usr/share/mk. We for a > period were using a script to wrap make to setup the environment before > we realized sys.mk was already capable of doing this. Being able to bind > a build to a specific environment is important, vs using the environment > installed from the last build or a foreign /usr/share/mk (FreeBSD's files). Sure, we use a wrapper script as it keeps life simple. > > But there's no reason you cannot make exceptions - by (as I think you > > already mentioned) adding a check for $SRCTOP/ports in local*sys*mk > > to suppress src.conf at least. > > > > Yes that has been my local fix for now. Ok - FWIW I don't see any particular problem with that. > Perhaps my fix should get checked in so no one else is surprised by > src.conf, and all of the tweaks its options set, coming in. Not sure I'd go that far. You could perhaps add a comment to src.conf for anyone who's frustrated?