From owner-svn-src-head@freebsd.org Fri Dec 4 21:51:30 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 675F7A419D7; Fri, 4 Dec 2015 21:51:30 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x241.google.com (mail-pa0-x241.google.com [IPv6:2607:f8b0:400e:c03::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 318A91513; Fri, 4 Dec 2015 21:51:30 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by padhk6 with SMTP id hk6so12438389pad.2; Fri, 04 Dec 2015 13:51:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=/5801M+Oj6hNrpr6PLeAI63eiKoJC6rQn0xgvC8Usnw=; b=bzqxusHywjZ+/r7q1kkin/mA4zbrPBmknYXzZvWAyB1wRvPrnMJZxHW4fpYvxlTz0L kP3T6gOnhQoCHMabWD6bfUaB1v3wx3tb3f9lAVEUAXyP4/aUTz7siyXQFBE6vruO2On+ KN5jXqtN48uTYgv/tXvuyzkZd/Hz7LRwPpIEK4Q0OFJ9AoB5E+z3lZppd2QLGYu4MgPN k+pR5s+7BsgUDz5zEk1RA9i1SDoxFbXPd8OTOdEwsBzgno2VoibQuz4yx7cXx04wt2Km smkRWrgDTNk6ITTJIbeek6WX2XDQBMcmeSApFlW33RdCBgk8Q9nR46X2YuVuGUjc53VH nNYA== X-Received: by 10.66.55.72 with SMTP id q8mr24893108pap.136.1449265889569; Fri, 04 Dec 2015 13:51:29 -0800 (PST) Received: from [22.7.185.75] ([172.56.16.161]) by smtp.gmail.com with ESMTPSA id q65sm19056762pfa.18.2015.12.04.13.51.27 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Dec 2015 13:51:27 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r291741 - head/sys/geom From: Garrett Cooper X-Mailer: iPhone Mail (13B143) In-Reply-To: <20151205064802.B4095@besplex.bde.org> Date: Fri, 4 Dec 2015 13:51:26 -0800 Cc: Bryan Drewery , Andrew Turner , "Kenneth D. Merry" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201512040338.tB43cZY1053263@repo.freebsd.org> <56610B6B.8010708@FreeBSD.org> <20151204233052.J2220@besplex.bde.org> <20151204125355.6712d782@bender> <20151205031713.T3286@besplex.bde.org> <5661E52D.6050305@FreeBSD.org> <20151205064802.B4095@besplex.bde.org> To: Bruce Evans X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 21:51:30 -0000 > On Dec 4, 2015, at 12:42, Bruce Evans wrote: ... > I wouldn't trust style(9) for anything except simple formatting, but > look at the subsystem(s) style. Just the top level of geom has 11000+ > lines which can be considered as giving about 20 times more examples > than style(9). It would be nice if we had more explicit rules in style(9).. Subtle interpre= tation like this is best left for philosophical and religious texts. The amount of time spent on checking code style (both your's, which is appre= ciated, and others), because style(9) wasn't explicit in areas is time bette= r spent on other things. -NGie=