From nobody Sat Jun 20 14:13:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gjGdk4lX7z6jd99 for ; Sat, 20 Jun 2026 14:13:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gjGdk403Yz3xym for ; Sat, 20 Jun 2026 14:13:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781964794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HoZD2+oAjIr6LQM6BhOSEusVmghp91lkghSXF7mfsSU=; b=l3lE7zduNdyYitMiUKSx/k4mHt+575DUMLXPxd/GwV9EUCXiOLRza2i5DhtYPE72wQVZTM GxoaNZ8tAUmuwBLgvM5xvits1gDWG2tCmjkFTcxkEL1GhzXZt29ZAWIaDWV6neQuo4KE0c vXfGcDhSYbBh/kFFUg9LmXTMjIXnPPmuNzqbT22erIM2WzQEHpx5yKbOPFfZhRkAMa6nKC Cx0nMjVwu3NY6Msy5tIBzYSRQVfAZn31isLZxS61ZRYTlItMOhoCYCStrW9mz1ZUU/VwwD NA02u5JWguOKTw0FiNAcdWO1NcUBqupeM9q50hmjdKQzVHWeRvTGGSgg3yojrQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781964794; a=rsa-sha256; cv=none; b=CxRzMc3gkHntACUHqsVE1GobgLeRo26tnzSkWB1XHzL2y/hWmE4y1k82zSS1X7UAsxrMgJ bzm7VNkwe8ptrR+zgStMBZCOT6vq31fVBm6FsqvyycjYC1MNavIWZY8p2jv/tkNUryWFzy 0t+3m8uVd9l8MHXV4LGucGOiCXh9E1YiLlKaR+F090io5veQKMMgfTOY5ayOEuDPo4yukt FhgU6lCYY3yXv4kC33eBU7kL0i6y/PPQq13NpIVchFBh7o9UCYeyfXUHevK9gjOrHx4yoM Kb8YXmYObJEy4zg3SFBdth+Vv/K5fFCFExwFRfp11Kf1CdIjG4fwQj/Nryq7bA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781964794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HoZD2+oAjIr6LQM6BhOSEusVmghp91lkghSXF7mfsSU=; b=UAJA+zLkZHCVlVJij55dlTUbrNwoasD8JXXp9C79zZPE/vogm22oSNRJFfG6cMFrxJaAdH 5rDoXyET/D8vT1fL5B/FwYR5s/2cLydhHWqrIFGBzohbn6zRDoI6Jf0eyGvcrVRSuBzb+M 5ER45EnivLVtXNuwTw552RvyN+yfnlJaqc+oHLJ3VlYXnQLIrjL67k0/59SCxGRMw8Q+xX uBSOBQ+J+Odu2ZXet/KJgfC2ogJ4nqaOLuPHDdD0gzO1OftGqKpkuh8kJalxVvDOZx2lVP gafNRKSj7p4qur8h+MxMKhCDtc43ZOsq50zoaZo7OsWB8R2Prt8b7iOpprlNeA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gjGdk2vVhzZww for ; Sat, 20 Jun 2026 14:13:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c35b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 20 Jun 2026 14:13:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: f7b71f832c99 - main - if_ovpn: Fix a lock leak in an error path List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f7b71f832c990da0bf203095f02405df665529d0 Auto-Submitted: auto-generated Date: Sat, 20 Jun 2026 14:13:09 +0000 Message-Id: <6a369ff5.3c35b.97f2cab@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=f7b71f832c990da0bf203095f02405df665529d0 commit f7b71f832c990da0bf203095f02405df665529d0 Author: Mark Johnston AuthorDate: 2026-06-20 14:12:19 +0000 Commit: Mark Johnston CommitDate: 2026-06-20 14:12:19 +0000 if_ovpn: Fix a lock leak in an error path Reviewed by: kp MFC after: 1 week Fixes: 04a7134c1e92 ("if_ovpn: fix use-after-free of mbuf") Differential Revision: https://reviews.freebsd.org/D57696 --- sys/net/if_ovpn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/net/if_ovpn.c b/sys/net/if_ovpn.c index 7c416055e939..b4796fb95589 100644 --- a/sys/net/if_ovpn.c +++ b/sys/net/if_ovpn.c @@ -2517,6 +2517,7 @@ ovpn_udp_input(struct mbuf *m, int off, struct inpcb *inp, m = m_unshare(m, M_NOWAIT); if (m == NULL) { + OVPN_RUNLOCK(sc); OVPN_COUNTER_ADD(sc, nomem_data_pkts_in, 1); if_inc_counter(sc->ifp, IFCOUNTER_IERRORS, 1); return (true);