From nobody Thu Dec 18 18:40:57 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dXKHZ0qZZz6LWWV for ; Thu, 18 Dec 2025 18:40:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dXKHY63n5z4D5w for ; Thu, 18 Dec 2025 18:40:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766083257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hNebrL/wJrFhf15lPkaTvvdpY49eLfYIJuVwLxLtz5s=; b=RtLjbuoCAwnBLdWfUHNItKucrvmXUiHMYPdcY19Up3ABeDgwNT5nQ32ir9vPytgNdLbIlI E7gGjs7RfTLVpC9k4jYYpge8lWIZYHssfq2u4mVQ3a/UZJISiydgeSEb2ph/IknUVn6HNd ncnpaUoixbFX5CbVj1cwvNJaraKOWMmX6z1gfcoXx9PIIQhcHM9cRGYBabs1mh9sspVhcp hjErXsMvo/7pSF/TxEktANRFQUKDydsvk+Jty0S3MyI6wBE1//93Uw4+cr6l7DVnBGZMVe cUKugGZTLNN2/uUoaixvjGA6YVInvGEsooaEGIK7kJXz2F6+AQ83EU5axwBf2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766083257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hNebrL/wJrFhf15lPkaTvvdpY49eLfYIJuVwLxLtz5s=; b=IeshEkO5DaaRtyJd5QhquqPGm9H0r9pLN6fU/Xh4DcnpX474kDr1FiWDrpZKs4zofGfBqh cMRXVmt/2AdEC+kVt6I7VbZSp6l3s8f2p4D3/E8Q7pZ0GqeJM0C2wP7rmprq8u7JhLrn/E xpGMCuiq+GPzlCAVymVkZun6eeFPREZY8bOPtbQyqpTnSWlgKZ+CssEfrZAPuk3m+jlOyO eGOGHrlF1uN4BiHehpshqefzxNy2TxcmnLYj/CXJcgSgexHKnEbdcDBvmcdUIkugODFfHF DEzWWPhniYZIBKRyQ4RjrMFW+Jn4GDmUwRrN0S3sVfTZrrqu3n+MOGPRRlaKjg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1766083257; a=rsa-sha256; cv=none; b=aMe4GTrldwyCT2ZcL+Lo4wFGX5JT+n8cW9yRKsCpL0mIVmgSm/f9IyGxUbWarKMxHKC/MH DpD9on0cEoZhRH0H/Vx0aXKKCeovm9xktMtJEWu5C+9WHEw2mtuVstO/5WGF5j85eciOSU 76jn3pySTJRHJxxWfgp/89+GzRpHp7OoL2aR5JPjZJp7UUuqVZe6/OG6KrL9ghltdc0QMe QJZG5FR7Ilf1nmiAfJldqrs624ps+U58JT2F/KFMklruygDdSSFASOthS156tCXjHIpSgO 7JdFXWdp78wk1UUBgxLY5cDCxcEiez+qw5CUEDicW3FBy0cKA0hgR2cyo3GWVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dXKHY5ZkTzqkf for ; Thu, 18 Dec 2025 18:40:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31a79 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 18 Dec 2025 18:40:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: c9be34e2e6af - stable/14 - aarch64: Clarify the initial adjustments to sp for kernel exception entry List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: c9be34e2e6af8ba22124b4c4229adb5db3006eda Auto-Submitted: auto-generated Date: Thu, 18 Dec 2025 18:40:57 +0000 Message-Id: <69444ab9.31a79.bd3ab2@gitrepo.freebsd.org> The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=c9be34e2e6af8ba22124b4c4229adb5db3006eda commit c9be34e2e6af8ba22124b4c4229adb5db3006eda Author: John Baldwin AuthorDate: 2025-09-16 11:21:39 +0000 Commit: John Baldwin CommitDate: 2025-12-18 18:24:20 +0000 aarch64: Clarify the initial adjustments to sp for kernel exception entry The first store-pair instruction in save_registers_head decrements the stack pointer to create room for most of the trapframe (and the redzone area for nested exceptions). However, the expression was a bit non-intuitive as it was using an expression without a leading negative sign to adjust the stack pointer. Rewrite the expression so that it is more clearly a negative adjustment to the stack pointer. Suggested by: andrew Reviewed by: andrew Sponsored by: AFRL, DARPA Differential Revision: https://reviews.freebsd.org/D52514 (cherry picked from commit 7314f78b240bdbf2bcec07e3d5a475e37941bb6b) --- sys/arm64/arm64/exception.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/arm64/arm64/exception.S b/sys/arm64/arm64/exception.S index 0df440863632..0457efe77ba8 100644 --- a/sys/arm64/arm64/exception.S +++ b/sys/arm64/arm64/exception.S @@ -39,9 +39,9 @@ .macro save_registers_head el .if \el == 1 mov x18, sp - stp x0, x1, [sp, #(TF_X - TF_SIZE - 128)]! + stp x0, x1, [sp, #-(TF_SIZE - TF_X + 128)]! .else - stp x0, x1, [sp, #(TF_X - TF_SIZE)]! + stp x0, x1, [sp, #-(TF_SIZE - TF_X)]! .endif stp x2, x3, [sp, #(2 * 8)] stp x4, x5, [sp, #(4 * 8)]