Date: Fri, 30 Jun 2023 15:40:42 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: Rob Wing <rob.fx907@gmail.com> Cc: Jessica Clarke <jrtc27@freebsd.org>, Mitchell Horne <mhorne@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org>, <sjg@juniper.net> Subject: Re: git: 56f3f2d2491e - main - libsecureboot: avoid set but not used errors Message-ID: <44286.1688164842@kaos.jnpr.net> In-Reply-To: <CAF3%2Bn_e9oSVh=jD-AeTPA0nfEpVkG2zyj8Cs-EL3=p4r92O7xg@mail.gmail.com> References: <202306300652.35U6qpgP027126@gitrepo.freebsd.org> <667C347E-B7C7-405B-AFEC-F0A0FD0656F6@freebsd.org> <498f3ba2-dc7a-e7d3-626a-76ca68cee5b2@freebsd.org> <B59305E1-680B-4793-9779-B872E76B6A34@freebsd.org> <79845.1688159657@kaos.jnpr.net> <CAF3%2Bn_e9oSVh=jD-AeTPA0nfEpVkG2zyj8Cs-EL3=p4r92O7xg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Rob Wing <rob.fx907@gmail.com> wrote:
> + if (!cn.status) {
> buf = NULL;
> + if (err == 0) /* keep compiler happy */
> + buf = NULL;
> + }
> return (buf);
> }
>
> And considering the comment at contrib/bearssl/inc/bearssl_x509.h
> is it intended for buf to be returned as-is (i.e., not set to NULL)
> when the decoding status indicates an error condition?
Good question, probably not, will fix.
Thanks for spotting.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44286.1688164842>