From owner-svn-src-all@freebsd.org Sat Nov 30 23:07:40 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BA33B1BB96F; Sat, 30 Nov 2019 23:07:40 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47QRqJ2pBJz4dfF; Sat, 30 Nov 2019 23:07:40 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id xAUN7Pc2023334 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 1 Dec 2019 01:07:29 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua xAUN7Pc2023334 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id xAUN7PHF023333; Sun, 1 Dec 2019 01:07:25 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 1 Dec 2019 01:07:25 +0200 From: Konstantin Belousov To: Mateusz Guzik Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355227 - head/sys/fs/tmpfs Message-ID: <20191130230725.GB10580@kib.kiev.ua> References: <201911301641.xAUGfmMt029299@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201911301641.xAUGfmMt029299@repo.freebsd.org> User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 47QRqJ2pBJz4dfF X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.96 / 15.00]; NEURAL_HAM_MEDIUM(-0.96)[-0.959,0]; NEURAL_HAM_LONG(-1.00)[-0.998,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Nov 2019 23:07:40 -0000 On Sat, Nov 30, 2019 at 04:41:48PM +0000, Mateusz Guzik wrote: > Author: mjg > Date: Sat Nov 30 16:41:47 2019 > New Revision: 355227 > URL: https://svnweb.freebsd.org/changeset/base/355227 > > Log: > tmpfs: add fast path to tmpfs_access for common case lookup > > VEXEC consists of vast majority of all calls and almost all targets have > at least 0111. On what load VEXEC is the dominant access check ? > > Modified: > head/sys/fs/tmpfs/tmpfs_vnops.c > > Modified: head/sys/fs/tmpfs/tmpfs_vnops.c > ============================================================================== > --- head/sys/fs/tmpfs/tmpfs_vnops.c Sat Nov 30 16:40:16 2019 (r355226) > +++ head/sys/fs/tmpfs/tmpfs_vnops.c Sat Nov 30 16:41:47 2019 (r355227) > @@ -331,6 +331,12 @@ tmpfs_access(struct vop_access_args *v) > > node = VP_TO_TMPFS_NODE(vp); > > + /* > + * Common case path lookup. > + */ > + if (__predict_true(accmode == VEXEC && (node->tn_mode & 0111) == 0111)) The 0111 must be spelled as (S_IXUSR | S_IXGRP | S_IXOTH). > + return (0); > + > switch (vp->v_type) { > case VDIR: > /* FALLTHROUGH */