From owner-cvs-all@FreeBSD.ORG Fri Dec 12 16:14:26 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D359816A4CE; Fri, 12 Dec 2003 16:14:26 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2838043D2D; Fri, 12 Dec 2003 16:14:26 -0800 (PST) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id hBD0EPXJ064474; Fri, 12 Dec 2003 16:14:25 -0800 (PST) (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.9/8.12.9/Submit) id hBD0EP5K064473; Fri, 12 Dec 2003 16:14:25 -0800 (PST) (envelope-from imp) Message-Id: <200312130014.hBD0EP5K064473@repoman.freebsd.org> From: Warner Losh Date: Fri, 12 Dec 2003 16:14:25 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/i386/isa stallion.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Dec 2003 00:14:27 -0000 imp 2003/12/12 16:14:25 PST FreeBSD src repository Modified files: (Branch: RELENG_4) sys/i386/isa stallion.c Log: Move check to see if you have too many panels to early in the loop rather than at the end where it suffered from a fencepost error. However, I'm not entirely sure that it is still correct because it looks like we access something in the ioaddr2 range. I need more stallion pannels to know for sure. The code is less incorrect than it was before at least when you have two pannels connected to the EC8/32-AT. Two pannels are allowed and appear to work. Stallion says that 3 cannot work, or when the agregate number of ports is > 32. I think that these tests should be more explicit, but until I have more hardware, this is less wrong. Revision Changes Path 1.39.2.4 +8 -8 src/sys/i386/isa/stallion.c