From owner-svn-src-all@freebsd.org Fri Jul 10 02:45:31 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 569AF9952E4 for ; Fri, 10 Jul 2015 02:45:31 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 22A1B1C51 for ; Fri, 10 Jul 2015 02:45:30 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by pdbqm3 with SMTP id qm3so31859644pdb.0 for ; Thu, 09 Jul 2015 19:45:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=bMv3Blii/XKASb5DDSuKJ2oXGj8FyXAy4D+SJcE3F7k=; b=C/3a9hFGBmw47yenO2GqK0nTQxMvtgIX2+ydduwgzPbwaQe2PDOzwx4+W9tvblr8CI NtDrs2oqeCGj0uCcB1mD9jEzGmmrXAJoeA9XIft5j9pWIwFgbTw70ZA/GXUA9dXUFz95 79kSEMYKDCm0tWoRvnoEk/TDO/TCoWGsUmEtb9EuphmaIgYmD++DzZSQhkPVNl6Cl+Rr 1NflbldM46MSdSj8ZIQkg4mbWOTxkEHm+mhS79VnJlfj1erXthn83IcfYj8c20RntuJq dgrGgKGai4YkBWnj2HUO4jkRPw4j8C/rKk/CtI5+U38E4gSh3Lbq1Z4oRDV+kH7QQ6+L zphA== X-Gm-Message-State: ALoCoQn21bgf2mCMxKfACel4HWwRveytd4OOdwcC8Mvh6FNxmwFUpWZmE8rNlEx/43U0VIKgEOc7 X-Received: by 10.68.238.39 with SMTP id vh7mr37703429pbc.12.1436496323873; Thu, 09 Jul 2015 19:45:23 -0700 (PDT) Received: from [10.64.26.138] ([69.53.236.236]) by smtp.gmail.com with ESMTPSA id pq3sm7203239pbb.24.2015.07.09.19.45.22 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 09 Jul 2015 19:45:22 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r285336 - in head/sys: netipsec opencrypto Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Content-Type: multipart/signed; boundary="Apple-Mail=_072917BF-D448-46F0-9753-F031D8F38D96"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5 From: Warner Losh In-Reply-To: Date: Thu, 9 Jul 2015 20:45:22 -0600 Cc: Peter Wemm , svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201507091816.t69IGawf097288@repo.freebsd.org> <15342729.MI2b1tqqeb@overcee.wemm.org> To: George Neville-Neil X-Mailer: Apple Mail (2.2102) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 02:45:31 -0000 --Apple-Mail=_072917BF-D448-46F0-9753-F031D8F38D96 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Jul 9, 2015, at 8:27 PM, George Neville-Neil = wrote: >=20 >=20 >=20 > On 9 Jul 2015, at 18:26, Peter Wemm wrote: >=20 >> On Thursday, July 09, 2015 06:16:36 PM George V. Neville-Neil wrote: >>> Author: gnn >>> Date: Thu Jul 9 18:16:35 2015 >>> New Revision: 285336 >>> URL: https://svnweb.freebsd.org/changeset/base/285336 >>>=20 >>> Log: >>> Add support for AES modes to IPSec. These modes work both in = software >>> only mode and with hardware support on systems that have AESNI >>> instructions. >>>=20 >>> Differential Revision: D2936 >>> Reviewed by: jmg, eri, cognet >>> Sponsored by: Rubicon Communications (Netgate) >>>=20 >>> Modified: >>> head/sys/netipsec/xform_ah.c >>> head/sys/netipsec/xform_esp.c >>=20 >>> @@ -953,6 +989,11 @@ esp_output_cb(struct cryptop *crp) >>> case CRYPTO_SHA2_512_HMAC: >>> alen =3D esph->hashsize/2; >>> break; >>> + case CRYPTO_AES_128_GMAC: >>> + case CRYPTO_AES_192_GMAC: >>> + case CRYPTO_AES_256_GMAC: >>> + alen =3D esph->hashsize; >>> + break; >>> default: >>> alen =3D AH_HMAC_HASHLEN; >>> break; >>=20 >> This introduces a LINT compile failure: >>=20 >> /usr/src/sys/netipsec/xform_esp.c:992:9: error: use of undeclared = identifier >> 'CRYPTO_AES_128_GMAC' >> case CRYPTO_AES_128_GMAC: >> ^ >> /usr/src/sys/netipsec/xform_esp.c:993:9: error: use of undeclared = identifier >> 'CRYPTO_AES_192_GMAC' >> case CRYPTO_AES_192_GMAC: >> ^ >> /usr/src/sys/netipsec/xform_esp.c:994:9: error: use of undeclared = identifier >> 'CRYPTO_AES_256_GMAC' >> case CRYPTO_AES_256_GMAC: >> ^ >> 3 errors generated. >> --- xform_esp.o --- >>=20 >=20 > Apologies, fixed in 285347. BTW The LINT conf in amd64 is ignored. = Why? What do you mean? Warner --Apple-Mail=_072917BF-D448-46F0-9753-F031D8F38D96 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVnzHCAAoJEGwc0Sh9sBEA7xsP/0RZHvusodBpr9ox2/qGOSBR Qi7Iha63+SuHqbfcU0ArO9GW31UggEqiDYUSMhek5cbT8WrdS08OAW4sCZzZIMoE GvyWzH9uzhq64OVDQG5OO8fPlQdq04EpjfBh+1xvcILJF8fky1DxamvUuI9mQJ99 QSssSODRrgxhNO3V2GgndzT8N7L/7r/Pt/k6/FqV2Klsd0gKT7+K2stwW9WcvzFx 2V5d0PgT0uXqKz0zKhMeGN7fhy6562uCSlxi+Ph32/BAJ3qgHZAOp/W3IZXuNlQP LtvEDDcnp4uEqjMu6sEC4xdUpqKUWnG1dNUjDmsoznY5eO5BPbjXi2cGjr391ceg 1gMyWzzzbMIyQ47KQHMi2hri4Ri+oECB8/FfrcfJmRffaow7+O5HOADG6biuDCfH Nd/kjcGi6OM0o7W0W3sK3jwBZpfW6esFKfW+aro94aBXStXxEgUS9EXKQYRbtKU9 WaG2paGamczKp6tefvUhnA+OaFNTjFEmYeO5X2WZhglm+2PY7YID7gdDWR5JZsBU EXdtJbBVTYB13esu4vHw5XyfUQrrMh2tynMbH80BXtexV3cCDVwbQ6oG7tacmGxk eNcj4aS6XJc/GON6pLh1s/HRPnWNmPcXt/Ks8+YL0U6yMeqhLwVvKe/8ITH83TrB 1qPwO1kyd0Qbww5dKhVC =P1pG -----END PGP SIGNATURE----- --Apple-Mail=_072917BF-D448-46F0-9753-F031D8F38D96--